Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Add native read support from ABFS storage #3580

Closed
gaoyangxiaozhu opened this issue Nov 1, 2023 · 5 comments · Fixed by #3897
Closed

[VL] Add native read support from ABFS storage #3580

gaoyangxiaozhu opened this issue Nov 1, 2023 · 5 comments · Fixed by #3897
Assignees
Labels
enhancement New feature or request

Comments

@gaoyangxiaozhu
Copy link
Contributor

Description

the abfs read support change has been ready in meta velox and also been synced by OAP/velox update branch, we can do chagne now in gluten to make the abfs read end to end work in OSS gluten repository.

I will take the job.

@gaoyangxiaozhu gaoyangxiaozhu added the enhancement New feature or request label Nov 1, 2023
@gaoyangxiaozhu
Copy link
Contributor Author

@zhli1142015 and @zhouyuan

@zhouyuan
Copy link
Contributor

zhouyuan commented Nov 1, 2023

@gaoyangxiaozhu @zhli1142015 thanks for the help, do you happen to have some ideas on how to validate this via tests? We currently have some S3(minio) related jobs running locally to verify the S3 adaptor.

-yuan

@gaoyangxiaozhu
Copy link
Contributor Author

@gaoyangxiaozhu @zhli1142015 thanks for the help, do you happen to have some ideas on how to validate this via tests? We currently have some S3(minio) related jobs running locally to verify the S3 adaptor.

-yuan

for read part we can leverage azurite simulator https://learn.microsoft.com/en-us/azure/storage/common/storage-use-azurite?tabs=visual-studio

@gaoyangxiaozhu
Copy link
Contributor Author

@zhouyuan how about make sperate PR for adding test with azurite, or you want me cover ut in this PR also ?

@zhouyuan
Copy link
Contributor

zhouyuan commented Dec 8, 2023

@zhouyuan how about make sperate PR for adding test with azurite, or you want me cover ut in this PR also ?

@gaoyangxiaozhu Hi, make senesce to me.

thanks, -yuan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants