Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3580][VL] support read data from abfs with account key #3897

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

gaoyangxiaozhu
Copy link
Contributor

@gaoyangxiaozhu gaoyangxiaozhu commented Nov 30, 2023

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

Fixes: #3580

How was this patch tested?

test maunally end to end

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

@gaoyangxiaozhu gaoyangxiaozhu changed the title support read data from abfs with account key [VL] support read data from abfs with account key Nov 30, 2023
Copy link

Run Gluten Clickhouse CI

@zhli1142015 zhli1142015 changed the title [VL] support read data from abfs with account key [GLUTEN-3580][VL] support read data from abfs with account key Nov 30, 2023
Copy link

#3580

@zhouyuan
Copy link
Contributor

zhouyuan commented Dec 1, 2023

@gaoyangxiaozhu thank you for adding ABFS support! Can you please help to fix the dependency installation also? something like gcs I think
https://github.com/oap-project/gluten/blob/main/ep/build-velox/src/get_velox.sh#L99

thanks, -yuan

Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

6 similar comments
Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Dec 8, 2023

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Dec 8, 2023

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Dec 8, 2023

Run Gluten Clickhouse CI

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhouyuan zhouyuan merged commit fb3bc84 into apache:main Dec 11, 2023
17 checks passed
@zhouyuan
Copy link
Contributor

Note: need follow up on

  • adding missing docs for abfs w/ gluten
  • enable the abfs build by default in GHA

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3897_time.csv log/native_master_12_10_2023_e9ea4e3e4_time.csv difference percentage
q1 34.09 34.68 0.592 101.74%
q2 25.13 27.19 2.067 108.22%
q3 37.75 37.58 -0.171 99.55%
q4 36.23 37.98 1.749 104.83%
q5 71.73 70.50 -1.235 98.28%
q6 7.35 6.93 -0.421 94.27%
q7 84.73 84.23 -0.501 99.41%
q8 86.23 85.45 -0.779 99.10%
q9 128.01 126.22 -1.790 98.60%
q10 43.19 43.28 0.086 100.20%
q11 21.28 19.94 -1.338 93.71%
q12 26.54 27.48 0.940 103.54%
q13 46.29 47.58 1.292 102.79%
q14 13.71 16.51 2.798 120.41%
q15 27.25 27.43 0.184 100.68%
q16 15.38 15.68 0.297 101.93%
q17 102.89 104.55 1.659 101.61%
q18 150.59 149.27 -1.324 99.12%
q19 13.01 13.60 0.587 104.51%
q20 27.56 27.18 -0.383 98.61%
q21 224.96 225.87 0.912 100.41%
q22 13.09 13.10 0.013 100.10%
total 1236.98 1242.22 5.235 100.42%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VL] Add native read support from ABFS storage
3 participants