Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test code depends on benchmark code #6553

Closed
xumingming opened this issue Jul 23, 2024 · 1 comment
Closed

Test code depends on benchmark code #6553

xumingming opened this issue Jul 23, 2024 · 1 comment

Comments

@xumingming
Copy link
Contributor

xumingming commented Jul 23, 2024

Problem description

There are two separate switches which controls whether we build test and whether we build benchmarks:

if(BUILD_TESTS)
  add_subdirectory(tests)
endif()

if(BUILD_BENCHMARKS)
  add_subdirectory(benchmarks)
endif()

But test code depends on benchmark lib unconditionally:

target_link_libraries(${TEST_EXEC} velox_benchmark_common GTest::gtest

System information

N/A

CMake log

No response

@FelixYBW
Copy link
Contributor

closed by #6563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants