Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't build gluten tests when BUILD_BENCHMARKS is not enabled #6562

Closed
NEUpanning opened this issue Jul 23, 2024 · 1 comment · Fixed by #6563
Closed

Can't build gluten tests when BUILD_BENCHMARKS is not enabled #6562

NEUpanning opened this issue Jul 23, 2024 · 1 comment · Fixed by #6563
Labels
BUILD triage

Comments

@NEUpanning
Copy link
Contributor

Problem description

Here are commands to reproduce

cd gluten/cpp
rm -rf cpp
./compile.sh --build_velox_backend=ON --build_tests=ON --build_examples=ON

System information

/

CMake log

/incubator-gluten/cpp/velox/tests/JsonToProtoConverter.cc:18:10: fatal error: velox/substrait/tests/JsonToProtoConverter.h: No such file or directory
   18 | #include "velox/substrait/tests/JsonToProtoConverter.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
In file included from /incubator-gluten/cpp/velox/compute/VeloxRuntime.h:20,
                 from /incubator-gluten/cpp/velox/tests/RuntimeTest.cc:18:
/incubator-gluten/cpp/velox/compute/WholeStageResultIterator.h:19:10: fatal error: compute/Runtime.h: No such file or directory
   19 | #include "compute/Runtime.h"
      |          ^~~~~~~~~~~~~~~~~~~
compilation terminated.
In file included from /incubator-gluten/cpp/velox/tests/VeloxColumnarToRowTest.cc:18:
/incubator-gluten/cpp/velox/memory/VeloxColumnarBatch.h:20:10: fatal error: memory/ColumnarBatch.h: No such file or directory
   20 | #include "memory/ColumnarBatch.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [velox/tests/CMakeFiles/velox_shuffle_writer_test.dir/build.make:90: velox/tests/CMakeFiles/velox_shuffle_writer_test.dir/JsonToProtoConverter.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from /incubator-gluten/cpp/velox/tests/BufferOutputStreamTest.cc:18:
/incubator-gluten/cpp/velox/memory/BufferOutputStream.h:20:10: fatal error: velox/buffer/Buffer.h: No such file or directory
   20 | #include "velox/buffer/Buffer.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [velox/tests/CMakeFiles/execution_ctx_test.dir/build.make:76: velox/tests/CMakeFiles/execution_ctx_test.dir/RuntimeTest.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/incubator-gluten/cpp/velox/tests/VeloxShuffleWriterTest.cc:18:10: fatal error: arrow/c/bridge.h: No such file or directory
   18 | #include <arrow/c/bridge.h>
      |          ^~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [velox/tests/CMakeFiles/velox_operators_test.dir/build.make:76: velox/tests/CMakeFiles/velox_operators_test.dir/VeloxColumnarToRowTest.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/incubator-gluten/cpp/velox/tests/JsonToProtoConverter.cc:18:10: fatal error: velox/substrait/tests/JsonToProtoConverter.h: No such file or directory
   18 | #include "velox/substrait/tests/JsonToProtoConverter.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
/incubator-gluten/cpp/velox/tests/JsonToProtoConverter.cc:18:10: fatal error: velox/substrait/tests/JsonToProtoConverter.h: No such file or directory
   18 | #include "velox/substrait/tests/JsonToProtoConverter.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
In file included from /incubator-gluten/cpp/velox/tests/VeloxColumnarBatchTest.cc:18:
/incubator-gluten/cpp/velox/memory/VeloxColumnarBatch.h:20:10: fatal error: memory/ColumnarBatch.h: No such file or directory
   20 | #include "memory/ColumnarBatch.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [velox/tests/CMakeFiles/buffer_outputstream_test.dir/build.make:76: velox/tests/CMakeFiles/buffer_outputstream_test.dir/BufferOutputStreamTest.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/incubator-gluten/cpp/velox/tests/VeloxRowToColumnarTest.cc:18:10: fatal error: memory/ArrowMemoryPool.h: No such file or directory
   18 | #include "memory/ArrowMemoryPool.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
/incubator-gluten/cpp/velox/tests/JsonToProtoConverter.cc:18:10: fatal error: velox/substrait/tests/JsonToProtoConverter.h: No such file or directory
   18 | #include "velox/substrait/tests/JsonToProtoConverter.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
/incubator-gluten/cpp/velox/tests/JsonToProtoConverter.cc:18:10: fatal error: velox/substrait/tests/JsonToProtoConverter.h: No such file or directory
   18 | #include "velox/substrait/tests/JsonToProtoConverter.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [velox/tests/CMakeFiles/buffer_outputstream_test.dir/build.make:90: velox/tests/CMakeFiles/buffer_outputstream_test.dir/JsonToProtoConverter.cc.o] Error 1
compilation terminated.
make[2]: *** [velox/tests/CMakeFiles/velox_shuffle_writer_test.dir/build.make:76: velox/tests/CMakeFiles/velox_shuffle_writer_test.dir/VeloxShuffleWriterTest.cc.o] Error 1
/incubator-gluten/cpp/velox/tests/JsonToProtoConverter.cc:18:10: fatal error: velox/substrait/tests/JsonToProtoConverter.h: No such file or directory
   18 | #include "velox/substrait/tests/JsonToProtoConverter.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [CMakeFiles/Makefile2:474: velox/tests/CMakeFiles/buffer_outputstream_test.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make[2]: *** [velox/tests/CMakeFiles/velox_memory_test.dir/build.make:90: velox/tests/CMakeFiles/velox_memory_test.dir/JsonToProtoConverter.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:318: velox/tests/CMakeFiles/velox_shuffle_writer_test.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
In file included from /incubator-gluten/cpp/velox/tests/MemoryManagerTest.cc:18:
/incubator-gluten/cpp/velox/benchmarks/common/BenchmarkUtils.h:20:10: fatal error: arrow/c/abi.h: No such file or directory
   20 | #include <arrow/c/abi.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [velox/tests/CMakeFiles/velox_operators_test.dir/build.make:118: velox/tests/CMakeFiles/velox_operators_test.dir/VeloxColumnarBatchTest.cc.o] Error 1
In file included from /incubator-gluten/cpp/velox/tests/VeloxSubstraitSignatureTest.cc:18:
/incubator-gluten/cpp/velox/substrait/VeloxSubstraitSignature.h:20:10: fatal error: velox/type/Type.h: No such file or directory
   20 | #include "velox/type/Type.h"
      |          ^~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [velox/tests/CMakeFiles/velox_operators_test.dir/build.make:132: velox/tests/CMakeFiles/velox_operators_test.dir/JsonToProtoConverter.cc.o] Error 1
make[2]: *** [velox/tests/CMakeFiles/velox_operators_test.dir/build.make:90: velox/tests/CMakeFiles/velox_operators_test.dir/VeloxRowToColumnarTest.cc.o] Error 1
make[2]: *** [velox/tests/CMakeFiles/execution_ctx_test.dir/build.make:90: velox/tests/CMakeFiles/execution_ctx_test.dir/JsonToProtoConverter.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:422: velox/tests/CMakeFiles/execution_ctx_test.dir/all] Error 2
make[2]: *** [velox/tests/CMakeFiles/velox_memory_test.dir/build.make:76: velox/tests/CMakeFiles/velox_memory_test.dir/MemoryManagerTest.cc.o] Error 1
/incubator-gluten/cpp/velox/tests/VeloxToSubstraitTypeTest.cc:18:10: fatal error: velox/common/base/tests/GTestUtils.h: No such file or directory
   18 | #include "velox/common/base/tests/GTestUtils.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [CMakeFiles/Makefile2:448: velox/tests/CMakeFiles/velox_memory_test.dir/all] Error 2
make[2]: *** [velox/tests/CMakeFiles/velox_plan_conversion_test.dir/build.make:146: velox/tests/CMakeFiles/velox_plan_conversion_test.dir/VeloxSubstraitSignatureTest.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [velox/tests/CMakeFiles/spark_functions_test.dir/build.make:104: velox/tests/CMakeFiles/spark_functions_test.dir/JsonToProtoConverter.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [velox/tests/CMakeFiles/velox_plan_conversion_test.dir/build.make:160: velox/tests/CMakeFiles/velox_plan_conversion_test.dir/VeloxToSubstraitTypeTest.cc.o] Error 1
/incubator-gluten/cpp/velox/tests/JsonToProtoConverter.cc:18:10: fatal error: velox/substrait/tests/JsonToProtoConverter.h: No such file or directory
   18 | #include "velox/substrait/tests/JsonToProtoConverter.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [velox/tests/CMakeFiles/velox_plan_conversion_test.dir/build.make:174: velox/tests/CMakeFiles/velox_plan_conversion_test.dir/JsonToProtoConverter.cc.o] Error 1
In file included from /incubator-gluten/cpp/velox/substrait/SubstraitExtensionCollector.h:21,
                 from /incubator-gluten/cpp/velox/tests/SubstraitExtensionCollectorTest.cc:18:
/incubator-gluten/cpp/velox/substrait/VeloxSubstraitSignature.h:20:10: fatal error: velox/type/Type.h: No such file or directory
   20 | #include "velox/type/Type.h"
      |          ^~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [velox/tests/CMakeFiles/velox_plan_conversion_test.dir/build.make:118: velox/tests/CMakeFiles/velox_plan_conversion_test.dir/SubstraitExtensionCollectorTest.cc.o] Error 1
/incubator-gluten/cpp/velox/tests/SparkFunctionTest.cc:21:10: fatal error: velox/functions/sparksql/tests/SparkFunctionBaseTest.h: No such file or directory
   21 | #include "velox/functions/sparksql/tests/SparkFunctionBaseTest.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [velox/tests/CMakeFiles/spark_functions_test.dir/build.make:76: velox/tests/CMakeFiles/spark_functions_test.dir/SparkFunctionTest.cc.o] Error 1
/incubator-gluten/cpp/velox/tests/VeloxSubstraitRoundTripTest.cc:23:10: fatal error: velox/common/base/tests/GTestUtils.h: No such file or directory
   23 | #include "velox/common/base/tests/GTestUtils.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [velox/tests/CMakeFiles/velox_plan_conversion_test.dir/build.make:132: velox/tests/CMakeFiles/velox_plan_conversion_test.dir/VeloxSubstraitRoundTripTest.cc.o] Error 1
[ 25%] Built target jni_proto
In file included from /incubator-gluten/cpp/velox/tests/Substrait2VeloxPlanValidatorTest.cc:21:
/incubator-gluten/cpp/velox/memory/VeloxMemoryManager.h:20:10: fatal error: memory/AllocationListener.h: No such file or directory
   20 | #include "memory/AllocationListener.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
/incubator-gluten/cpp/velox/tests/FunctionTest.cc:21:10: fatal error: velox/common/base/Fs.h: No such file or directory
   21 | #include "velox/common/base/Fs.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
/incubator-gluten/cpp/velox/tests/Substrait2VeloxValuesNodeConversionTest.cc:21:10: fatal error: velox/common/base/Fs.h: No such file or directory
   21 | #include "velox/common/base/Fs.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [velox/tests/CMakeFiles/velox_plan_conversion_test.dir/build.make:90: velox/tests/CMakeFiles/velox_plan_conversion_test.dir/Substrait2VeloxPlanValidatorTest.cc.o] Error 1
make[2]: *** [velox/tests/CMakeFiles/spark_functions_test.dir/build.make:90: velox/tests/CMakeFiles/spark_functions_test.dir/FunctionTest.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:396: velox/tests/CMakeFiles/spark_functions_test.dir/all] Error 2
make[2]: *** [velox/tests/CMakeFiles/velox_plan_conversion_test.dir/build.make:104: velox/tests/CMakeFiles/velox_plan_conversion_test.dir/Substrait2VeloxValuesNodeConversionTest.cc.o] Error 1
/incubator-gluten/cpp/velox/tests/VeloxColumnarBatchSerializerTest.cc:20:10: fatal error: memory/ArrowMemoryPool.h: No such file or directory
   20 | #include "memory/ArrowMemoryPool.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [velox/tests/CMakeFiles/velox_operators_test.dir/build.make:104: velox/tests/CMakeFiles/velox_operators_test.dir/VeloxColumnarBatchSerializerTest.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:344: velox/tests/CMakeFiles/velox_operators_test.dir/all] Error 2
In file included from /incubator-gluten/cpp/velox/tests/Substrait2VeloxPlanConversionTest.cc:21:
/incubator-gluten/cpp/velox/compute/VeloxPlanConverter.h:20:10: fatal error: velox/common/memory/MemoryPool.h: No such file or directory
   20 | #include <velox/common/memory/MemoryPool.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [velox/tests/CMakeFiles/velox_plan_conversion_test.dir/build.make:76: velox/tests/CMakeFiles/velox_plan_conversion_test.dir/Substrait2VeloxPlanConversionTest.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:370: velox/tests/CMakeFiles/velox_plan_conversion_test.dir/all] Error 2
make: *** [Makefile:146: all] Error 2
@NEUpanning NEUpanning mentioned this issue Jul 23, 2024
Merged
@PHILO-HE
Copy link
Contributor

Relevant issue: #6553.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BUILD triage
Projects
None yet
Milestone
No milestone
2 participants
@PHILO-HE @NEUpanning