[GLUTEN-6562][VL] Decouple BUILD_BENCHMARKS and BUILD_TESTS build options #6563
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
NEUpanning
changed the title
|
@xumingming, I note you also found this issue, could you take a review? |
|
Is it possible to not mix BUILD_TESTS and BUILD_BENCHMARKS together? I think it is cleaner, what we need to do is do not let tests code depends on benchmark related code. |
@xumingming, I agree. @NEUpanning, we may need to extract out the shared code from benchmark module. |
|
@PHILO-HE @xumingming I have updated the code so that the gluten tests no longer depends on the gluten benchmarks. |
cpp/velox/tests/CMakeLists.txt
Outdated
| target_link_libraries(${TEST_EXEC} velox_benchmark_common GTest::gtest | ||
| GTest::gtest_main) | ||
| target_link_libraries(${TEST_EXEC} velox GTest::gtest GTest::gtest_main | ||
| google::glog benchmark::benchmark) |
There was a problem hiding this comment.
Why benchmark::benchmark is needed?
There was a problem hiding this comment.
Thanks. I've remove it.
|
Looks good to me. |
NEUpanning
force-pushed
the
enable_build_benchmark
branch
from
7b90371 to
803b99f
Compare
PHILO-HE
changed the title
…nFallbackSummary fix (#7919)
What changes were proposed in this pull request?
Building Gluten tests depends on gluten benchmark , this pr decouples them.
Fixes: #6562
How was this patch tested?
I successfully built gluten tests with
./compile.sh --build_velox_backend=ON --build_tests=ON --build_examples=ONthat BUILD_BENCHMARKS is not enabled