Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-2031][VL] Enable lag window function #2737

Merged
merged 2 commits into from
Feb 28, 2024
Merged

[GLUTEN-2031][VL] Enable lag window function #2737

merged 2 commits into from
Feb 28, 2024

Conversation

PHILO-HE
Copy link
Contributor

What changes were proposed in this pull request?

Support lag window function.

How was this patch tested?

Spark UT.

@github-actions
Copy link

#2031

winningsix
winningsix reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@winningsix winningsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tests needed to be enabled for Lag function? Also, we can update doc.

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale stale label Nov 17, 2023
@github-actions github-actions bot removed the stale stale label Nov 18, 2023
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

2 similar comments
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Run Gluten Clickhouse CI

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

1 similar comment
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale stale label Feb 13, 2024
@github-actions GitHub Actions
Copy link

This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.

@github-actions github-actions bot closed this Feb 24, 2024
@PHILO-HE PHILO-HE reopened this Feb 27, 2024
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions github-actions bot removed the stale stale label Feb 28, 2024
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

rui-mo
rui-mo reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@rui-mo rui-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any test to ensure lag can be offloaded?

@PHILO-HE
Copy link
Contributor Author

PHILO-HE commented Feb 28, 2024 •
edited
Loading

Is there any test to ensure lag can be offloaded?

Just added a test. Thanks!

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@PHILO-HE PHILO-HE merged commit 65fb100 into apache:main Feb 28, 2024
19 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_2737_time.csv log/native_master_02_27_2024_94c8e7e0e_time.csv difference percentage
q1 32.94 33.59 0.645 101.96%
q2 24.40 24.40 -0.003 99.99%
q3 38.89 38.91 0.018 100.05%
q4 37.65 36.13 -1.514 95.98%
q5 71.79 70.98 -0.812 98.87%
q6 5.49 7.08 1.599 129.15%
q7 83.54 84.44 0.904 101.08%
q8 85.08 86.39 1.304 101.53%
q9 127.30 121.48 -5.823 95.43%
q10 44.22 44.06 -0.161 99.64%
q11 20.42 19.96 -0.459 97.75%
q12 25.16 29.43 4.277 117.00%
q13 45.30 45.22 -0.082 99.82%
q14 17.06 16.33 -0.737 95.68%
q15 28.98 28.90 -0.085 99.71%
q16 13.82 15.96 2.148 115.54%
q17 102.31 103.10 0.796 100.78%
q18 148.86 148.22 -0.643 99.57%
q19 14.21 12.53 -1.683 88.16%
q20 26.09 26.71 0.617 102.36%
q21 226.06 224.21 -1.854 99.18%
q22 13.68 13.66 -0.016 99.88%
total 1233.28 1231.71 -1.567 99.87%

WangGuangxin pushed a commit to WangGuangxin/gluten that referenced this pull request May 14, 2024
@PHILO-HE @WangGuangxin
[GLUTEN-2031][VL] Enable lag window function (apache#2737)
b225d14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winningsix winningsix winningsix left review comments

@rui-mo rui-mo rui-mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PHILO-HE @GlutenPerfBot @winningsix @rui-mo