Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-2874][VL] support allowDecimalPrecisionLoss #2895

Merged
merged 8 commits into from
Jul 5, 2024
Merged

[GLUTEN-2874][VL] support allowDecimalPrecisionLoss #2895

merged 8 commits into from
Jul 5, 2024

Conversation

zhouyuan
Copy link
Contributor

@zhouyuan zhouyuan commented Aug 25, 2023 •
edited
Loading

What changes were proposed in this pull request?

This patch allows user to enable or disable decimal precision loss in decimal arithmetic

this patch depends on oap-project/velox#394

(Fixes: #2874)

How was this patch tested?

existing UT

@github-actions
Copy link

#2874

@zhouyuan zhouyuan force-pushed the wip_decimal_precision_loss branch from 77c1755 to 1cc2048 Compare August 25, 2023 02:32
@github-actions
Copy link

Run Gluten Clickhouse CI

@zhouyuan zhouyuan changed the title [GLUTEN-2874][VL] support allowDecimalPrecisionLoss [DNM][GLUTEN-2874][VL] support allowDecimalPrecisionLoss Aug 25, 2023
@zhouyuan zhouyuan force-pushed the wip_decimal_precision_loss branch from 1cc2048 to 43f847d Compare August 25, 2023 02:35
@github-actions
Copy link

Run Gluten Clickhouse CI

@zhouyuan zhouyuan added the meta/velox patch to catch up with meta/velox label Aug 25, 2023
@zhouyuan zhouyuan changed the base branch from main to upstream_velox August 25, 2023 02:53
@zhouyuan zhouyuan changed the base branch from upstream_velox to main August 25, 2023 02:55
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale stale label Nov 17, 2023
@github-actions GitHub Actions
Copy link

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Nov 28, 2023
@zhouyuan zhouyuan reopened this Nov 28, 2023
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions github-actions bot removed the stale stale label Nov 29, 2023
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale stale label Feb 13, 2024
@github-actions GitHub Actions
Copy link

This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.

@github-actions github-actions bot closed this Feb 24, 2024
@zhouyuan zhouyuan reopened this Feb 27, 2024
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions github-actions bot removed the stale stale label Feb 28, 2024
@zhouyuan zhouyuan force-pushed the wip_decimal_precision_loss branch from 43f847d to bb88e9f Compare February 28, 2024 03:00
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@zhouyuan zhouyuan force-pushed the wip_decimal_precision_loss branch from bb88e9f to 7036fd4 Compare February 28, 2024 03:37
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@zhouyuan zhouyuan force-pushed the wip_decimal_precision_loss branch from 7036fd4 to 20164ec Compare February 28, 2024 06:56
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@zhouyuan zhouyuan force-pushed the wip_decimal_precision_loss branch from 20164ec to 190cf33 Compare February 28, 2024 07:58
@github-actions github-actions bot added the stale stale label Apr 22, 2024
@zhouyuan zhouyuan removed the stale stale label Apr 22, 2024
@zhouyuan zhouyuan force-pushed the wip_decimal_precision_loss branch from 64a1f0d to d5c8f5b Compare May 6, 2024 08:25
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Run Gluten Clickhouse CI

@zhouyuan zhouyuan force-pushed the wip_decimal_precision_loss branch from d5c8f5b to ab940e7 Compare May 6, 2024 08:37
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Run Gluten Clickhouse CI

@zhouyuan zhouyuan force-pushed the wip_decimal_precision_loss branch from ab940e7 to 67fa019 Compare May 6, 2024 12:11
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Run Gluten Clickhouse CI

zhouyuan added 2 commits May 7, 2024 07:41
@zhouyuan
fix ck backend
1d6e458 
Signed-off-by: Yuan Zhou <[email protected]>
@zhouyuan
add back config in native
b715dfd 
Signed-off-by: Yuan Zhou <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Run Gluten Clickhouse CI

@zhouyuan
fix
65eead9 
Signed-off-by: Yuan Zhou <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Run Gluten Clickhouse CI

@kecookier
Copy link
Contributor

@zhouyuan I have tested this PR in my situation, and it looks good to me. Thanks!

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale stale label Jun 22, 2024
@zhouyuan zhouyuan removed the stale stale label Jun 28, 2024
@kecookier
Copy link
Contributor

@zhouyuan Hi there, could you please let me know the current status of this PR? Will it be included in the release-1.2.0 version? Thanks!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Run Gluten Clickhouse CI

@zhouyuan
fix param name
ac1e04d 
Signed-off-by: Yuan Zhou <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Run Gluten Clickhouse CI

@zhouyuan
fix format
57bb881 
Signed-off-by: Yuan Zhou <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

#2874

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Run Gluten Clickhouse CI

marin-ma
marin-ma approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@marin-ma marin-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhouyuan zhouyuan merged commit b0b7ae9 into apache:main Jul 5, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marin-ma marin-ma marin-ma approved these changes

Assignees
No one assigned
Labels
meta/velox patch to catch up with meta/velox
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[VL] support spark.sql.decimalOperations.allowPrecisionLoss
3 participants
@zhouyuan @kecookier @marin-ma