-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Refactor split buffer allocation #3177
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
56bf7bd
to
b5f4579
Compare
Run Gluten Clickhouse CI |
b5f4579
to
cc29bd2
Compare
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
501666c
to
2b17f93
Compare
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
2b17f93
to
ea89f45
Compare
Run Gluten Clickhouse CI |
e84cf0f
to
bd3cd5a
Compare
Run Gluten Clickhouse CI |
bd3cd5a
to
ac0ba92
Compare
/Benchmark Velox |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
/Benchmark Velox |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
@FelixYBW Could you help to review? Thanks! |
/Benchmark Velox |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work!
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Extract the duplicated logic in both
resizePartitionBuffer
andallocatePartitionBuffer
.In prealloc partition buffer, use
resizePartitionBuffer
instead ofallocatePartitionBuffer
if need to preserve buffer data for the next split, and remove the resize branch inallocate PartitionBuffer
.