-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-3473][VL] Add rapidjson-dev library to the setup instructions #3474
[GLUTEN-3473][VL] Add rapidjson-dev library to the setup instructions #3474
Conversation
… for the dependencies to build.
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
need we add to vcpk? |
@FelixYBW I don't think so: on a machine where I built it successfully I did |
CC @FelixYBW can you review? |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Does anyone have time to review doc changes or should I drop this? |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. |
as it is required for the dependencies to build.
What changes were proposed in this pull request?
Add rapidjson-dev library to the setup instructions
Fixes #3473
How was this patch tested?
Installed rapidjson-dev and re-ran setup script got success
See https://www.youtube.com/watch?v=UbB7v2f7A6k