Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3473][VL] Add rapidjson-dev library to the setup instructions #3474

Closed

Conversation

holdenk
Copy link
Contributor

@holdenk holdenk commented Oct 20, 2023

as it is required for the dependencies to build.

What changes were proposed in this pull request?

Add rapidjson-dev library to the setup instructions

Fixes #3473

How was this patch tested?

Installed rapidjson-dev and re-ran setup script got success

See https://www.youtube.com/watch?v=UbB7v2f7A6k

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zhztheplayer zhztheplayer changed the title [GLUTEN-<issue ID>][VL] Add rapidjson-dev library to the setup instructions [GLUTEN-3473][VL] Add rapidjson-dev library to the setup instructions Oct 23, 2023
@github-actions
Copy link

#3473

@FelixYBW
Copy link
Contributor

need we add to vcpk?

@holdenk
Copy link
Contributor Author

holdenk commented Nov 3, 2023

@FelixYBW I don't think so: on a machine where I built it successfully I did sudo apt-get remove librust-vcpkg-dev and it was not installed.

@holdenk
Copy link
Contributor Author

holdenk commented Nov 5, 2023

CC @FelixYBW can you review?

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale stale label Dec 21, 2023
@holdenk
Copy link
Contributor Author

holdenk commented Dec 26, 2023

Does anyone have time to review doc changes or should I drop this?

@github-actions github-actions bot removed the stale stale label Dec 27, 2023
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale stale label Feb 13, 2024
Copy link

This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.

@github-actions github-actions bot closed this Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rapidjson library needs to be installed for velox build but it is not part of the apt-get setup instructions
2 participants