Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Use existing constructor for BigintRange and MultiRange #3508

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

rui-mo
Copy link
Contributor

@rui-mo rui-mo commented Oct 24, 2023

What changes were proposed in this pull request?

Use existing constructor for BigintRange and MultiRange in Velox.
Revert constructor changes with oap-project/velox#423.

How was this patch tested?

under test

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@PHILO-HE
Copy link
Contributor

Looks good!

@rui-mo rui-mo merged commit 9197780 into apache:main Oct 25, 2023
13 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3508_time.csv log/native_master_10_24_2023_277d1c4a7_time.csv difference percentage
q1 34.59 34.96 0.367 101.06%
q2 24.93 25.20 0.265 101.06%
q3 40.26 40.14 -0.119 99.70%
q4 37.04 37.18 0.142 100.38%
q5 72.30 69.60 -2.695 96.27%
q6 8.70 8.82 0.114 101.31%
q7 87.50 88.00 0.497 100.57%
q8 85.56 87.02 1.458 101.70%
q9 120.76 121.90 1.140 100.94%
q10 54.48 53.59 -0.893 98.36%
q11 19.34 20.02 0.682 103.52%
q12 27.32 26.72 -0.598 97.81%
q13 49.37 49.37 0.007 100.01%
q14 18.15 18.89 0.745 104.10%
q15 35.71 34.21 -1.499 95.80%
q16 16.26 16.39 0.128 100.79%
q17 98.91 102.21 3.299 103.34%
q18 148.55 148.12 -0.427 99.71%
q19 16.94 16.93 -0.016 99.91%
q20 31.12 31.30 0.180 100.58%
q21 224.22 223.35 -0.864 99.61%
q22 13.17 13.34 0.170 101.29%
total 1265.17 1267.25 2.083 100.16%

@rui-mo rui-mo deleted the wip_range branch February 20, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants