Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3542][CH] Cancel empty string as null representation when readi… #3543

Merged
merged 7 commits into from
Nov 3, 2023
Merged

[GLUTEN-3542][CH] Cancel empty string as null representation when readi… #3543

merged 7 commits into from
Nov 3, 2023

Conversation

lhuang09287750
Copy link
Contributor

…ng csv with excel format

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #3542)

How was this patch tested?

change test case in GlutenClickHouseFileFormatSuite

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@github-actions
Copy link

Run Gluten Clickhouse CI

@lhuang09287750 lhuang09287750 changed the title fix issue-3542, cancel empty string as null representation when readi… [GLUTEN-3542][CH]Cancel empty string as null representation when readi… Oct 26, 2023
@github-actions
Copy link

#3542

@PHILO-HE PHILO-HE changed the title [GLUTEN-3542][CH]Cancel empty string as null representation when readi… [GLUTEN-3542][CH] Cancel empty string as null representation when readi… Oct 30, 2023
@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@loneylee
Copy link
Member

LGTM

@github-actions
Copy link

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Nov 3, 2023

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Nov 3, 2023

Run Gluten Clickhouse CI

Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baibaichen baibaichen merged commit 1bacef5 into apache:main Nov 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] cancel empty string as null representation when reading csv with excel format
4 participants