-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-3602][VL] Sed install_awssdk function to setup-centos8.sh#velox on centos8 #3600
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
@ulysses-you Apology if bother you. Could you please start this workflow? I want to verify a suspected bug —— |
Run Gluten Clickhouse CI |
@ulysses-you Thanks and I submit an issue #3602. I am working on this ticket. |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
@zhouyuan ready to review :) |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
@zhouyuan Only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We should probably turn on HDFS & S3 connectors by default to make the code covered by more tests.
CC: @PHILO-HE
@dcoliversun thank you for reporting, and also the good fix! -yuan |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
When exec
./get_velox.sh --enable_s3=on & ./build_velox.sh
, we have a error with command not foundThis is caused by lack of
install_awssdk
function after rebase.(Fixes: #3602)
How was this patch tested?
Set
enable_s3
as ON in github action.