Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Replace string comparisons with enum for shuffle partitioning #3611

Merged
merged 2 commits into from
Nov 4, 2023

Conversation

marin-ma
Copy link
Contributor

@marin-ma marin-ma commented Nov 3, 2023

This PR replaces string comparisons with enums for shuffle partitioning and includes some cleanup in the creation of partitioners. It does not introduce any changes to functionality.

Copy link

github-actions bot commented Nov 3, 2023

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link
Contributor

@JkSelf JkSelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@marin-ma marin-ma merged commit 16e2874 into apache:main Nov 4, 2023
15 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3611_time.csv log/native_master_11_03_2023_13a0a6335_time.csv difference percentage
q1 35.71 34.17 -1.547 95.67%
q2 24.95 25.09 0.143 100.57%
q3 40.43 39.87 -0.562 98.61%
q4 37.36 37.07 -0.289 99.23%
q5 69.35 70.79 1.443 102.08%
q6 8.88 8.97 0.088 100.99%
q7 88.65 88.68 0.024 100.03%
q8 86.71 87.82 1.113 101.28%
q9 120.53 121.60 1.063 100.88%
q10 51.67 52.15 0.480 100.93%
q11 20.53 20.26 -0.277 98.65%
q12 26.67 27.25 0.574 102.15%
q13 48.18 48.45 0.269 100.56%
q14 20.29 18.58 -1.709 91.58%
q15 35.33 33.71 -1.623 95.41%
q16 16.02 15.93 -0.094 99.42%
q17 102.65 100.69 -1.965 98.09%
q18 147.62 147.73 0.109 100.07%
q19 16.89 16.82 -0.071 99.58%
q20 32.90 32.51 -0.395 98.80%
q21 224.00 221.69 -2.307 98.97%
q22 13.49 13.44 -0.044 99.68%
total 1268.81 1263.24 -5.579 99.56%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_11_04_2023_time.csv log/native_master_11_03_2023_13a0a6335_time.csv difference percentage
q1 35.71 34.17 -1.544 95.68%
q2 25.11 25.09 -0.017 99.93%
q3 41.04 39.87 -1.177 97.13%
q4 37.02 37.07 0.045 100.12%
q5 69.89 70.79 0.895 101.28%
q6 8.78 8.97 0.189 102.15%
q7 85.70 88.68 2.976 103.47%
q8 87.58 87.82 0.241 100.27%
q9 123.10 121.60 -1.502 98.78%
q10 51.16 52.15 0.988 101.93%
q11 20.85 20.26 -0.598 97.13%
q12 27.21 27.25 0.034 100.12%
q13 49.22 48.45 -0.770 98.43%
q14 19.44 18.58 -0.856 95.60%
q15 34.88 33.71 -1.170 96.65%
q16 16.43 15.93 -0.505 96.92%
q17 102.46 100.69 -1.769 98.27%
q18 147.44 147.73 0.289 100.20%
q19 16.84 16.82 -0.017 99.90%
q20 33.76 32.51 -1.257 96.28%
q21 223.98 221.69 -2.289 98.98%
q22 13.44 13.44 0.005 100.04%
total 1271.05 1263.24 -7.811 99.39%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_11_05_2023_time.csv log/native_master_11_04_2023_16e287450_time.csv difference percentage
q1 34.85 35.71 0.858 102.46%
q2 25.12 25.11 -0.007 99.97%
q3 40.11 41.04 0.934 102.33%
q4 37.09 37.02 -0.070 99.81%
q5 71.44 69.89 -1.548 97.83%
q6 9.10 8.78 -0.317 96.52%
q7 87.61 85.70 -1.912 97.82%
q8 85.22 87.58 2.367 102.78%
q9 121.12 123.10 1.977 101.63%
q10 51.83 51.16 -0.673 98.70%
q11 19.68 20.85 1.176 105.98%
q12 28.01 27.21 -0.802 97.14%
q13 48.61 49.22 0.606 101.25%
q14 19.14 19.44 0.300 101.57%
q15 33.03 34.88 1.850 105.60%
q16 16.10 16.43 0.328 102.04%
q17 102.08 102.46 0.380 100.37%
q18 149.04 147.44 -1.605 98.92%
q19 18.25 16.84 -1.409 92.28%
q20 30.91 33.76 2.850 109.22%
q21 222.95 223.98 1.032 100.46%
q22 13.47 13.44 -0.031 99.77%
total 1264.76 1271.05 6.285 100.50%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants