Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] GHA CI: Add cases for aggregation within limited memory #3622

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Nov 6, 2023

To test Q23A/Q23B within 3 different partial aggregation modes:

  1. PARTIAL_MODE:ABANDONED
    Abandons partial aggregation immediately
  2. PARTIAL_MODE:CACHED
    Do full partial aggregation, use as much of memory as possible
  3. PARTIAL_MODE:FLUSHED
    Partial flushes data when reaching 0.1 * executor off-heap memory limit

Q97 is basically for testing distinct aggregation.

The failures are ignored until the related OOM issues are fixed.

Copy link

github-actions bot commented Nov 6, 2023

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer changed the title [VL] GHA CI: Add an case for aggregation within limited memory [VL] GHA CI: Add a case for aggregation within limited memory Nov 6, 2023
Copy link

github-actions bot commented Nov 6, 2023

Run Gluten Clickhouse CI

@apache apache deleted a comment from github-actions bot Nov 6, 2023
Copy link

github-actions bot commented Nov 6, 2023

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Nov 6, 2023

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer changed the title [VL] GHA CI: Add a case for aggregation within limited memory [VL] GHA CI: Add cases for aggregation within limited memory Nov 6, 2023
@zhztheplayer zhztheplayer marked this pull request as ready for review November 6, 2023 08:35
Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhztheplayer zhztheplayer merged commit 40ef132 into apache:main Nov 7, 2023
20 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3622_time.csv log/native_master_11_06_2023_d57fdf26f_time.csv difference percentage
q1 33.61 33.34 -0.269 99.20%
q2 25.17 24.84 -0.326 98.71%
q3 38.85 38.31 -0.548 98.59%
q4 37.40 37.40 -0.001 100.00%
q5 71.12 70.83 -0.290 99.59%
q6 7.99 7.74 -0.251 96.85%
q7 83.19 85.97 2.789 103.35%
q8 87.05 84.68 -2.369 97.28%
q9 118.78 124.39 5.614 104.73%
q10 50.93 54.67 3.740 107.34%
q11 20.80 19.96 -0.842 95.95%
q12 25.82 24.52 -1.305 94.94%
q13 48.90 50.37 1.465 103.00%
q14 19.80 18.50 -1.296 93.45%
q15 30.40 32.09 1.698 105.59%
q16 16.78 16.51 -0.273 98.37%
q17 100.61 100.90 0.290 100.29%
q18 149.59 148.27 -1.316 99.12%
q19 14.81 14.74 -0.067 99.55%
q20 29.40 30.95 1.546 105.26%
q21 225.42 225.06 -0.361 99.84%
q22 13.40 13.61 0.205 101.53%
total 1249.82 1257.65 7.834 100.63%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants