Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM][VL] enable hash build side selection #3626

Closed
wants to merge 2 commits into from

Conversation

zhouyuan
Copy link
Contributor

@zhouyuan zhouyuan commented Nov 6, 2023

What changes were proposed in this pull request?

Allow to build with smaller side on LeftOuter, LeftSemi, RightOuter

(Fixes: #ISSUE-ID)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

github-actions bot commented Nov 6, 2023

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zhouyuan zhouyuan force-pushed the wip_hash_build_side branch from 25f8db9 to 36bbcd3 Compare November 6, 2023 05:18
@zhouyuan
Copy link
Contributor Author

zhouyuan commented Nov 6, 2023

@zhztheplayer here's the patch for always build with smaller table in hash join

Copy link

github-actions bot commented Nov 6, 2023

Run Gluten Clickhouse CI

@zhouyuan zhouyuan force-pushed the wip_hash_build_side branch from 4b22b51 to 4400641 Compare November 8, 2023 00:54
Copy link

github-actions bot commented Nov 8, 2023

Run Gluten Clickhouse CI

@zhouyuan zhouyuan force-pushed the wip_hash_build_side branch from 4400641 to e592d2c Compare November 8, 2023 03:04
Copy link

github-actions bot commented Nov 8, 2023

Run Gluten Clickhouse CI

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale stale label Dec 24, 2023
@zhouyuan zhouyuan removed the stale stale label Dec 24, 2023
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale stale label Feb 13, 2024
Copy link

This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.

@github-actions github-actions bot closed this Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant