-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] [Test] Test rebasing upstream velox 11_8 #3642
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
/Benchmark Velox |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
6a27cf3
to
dfa86bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How many tets are affected by Velox's change? If there are many of them, maybe we should consider removing duplicated keys in Gluten before sending to Velox.
@rui-mo Only Q72 in TPC-DS is affected. Maybe we can remove the duplicated keys in the follow PRs. |
How does its fallback affect the performance of q72? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@rui-mo There is no performance impact. |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
In the upstream Velox, it is ensured that the sorting key is unique in TopNode here. Therefore, we add a check for this in this PR.
How was this patch tested?
Pass CI.