[GLUTEN-3625][FOLLOWUP] Fix IDEA load module issue #3647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
|
I always enable all the Spark profiles, so did not realize the idea issue.. @zzcclp can you try this pr ? thank you |
|
cc @baibaichen |
PHILO-HE
reviewed
Nov 8, 2023
| <modules> | ||
| <module>common</module> | ||
| <module>${spark.test.module}</module> | ||
| </modules> |
There was a problem hiding this comment.
Does it work if just adding the below in shims/pom.xml, similar to the above?
<modules>
<module>common</module>
<module>${spark.shim.module}</module>
</modules>
There was a problem hiding this comment.
addessed and manually verified
|
manually test, it works for me in IDEA. |
|
Run Gluten Clickhouse CI |
PHILO-HE
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Thanks for your quick response!
Let's wait for @baibaichen to verify. @zzcclp, please re-confirm the latest changes. Thanks!
|
it's ok now. let's merge! |
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
ulysses-you
added a commit
to ulysses-you/gluten
that referenced
this pull request
Dec 7, 2023
* Fix idea load module issue * address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix IDEA load module issue
How was this patch tested?
manually test