[GLUTEN-3668][CH] Performance regresses seriously after PR 3169 merge when executing convert string to date #3671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when executing convert string to date PR apache#3169 add some functions to convert string to date, which leads to performance regression serious. Will be reverted first and raise another pr to fix the issue later. Test case, 2000W records: before PR apache#3169 : 3s after PR apache#3169: 3.6m Related PR: apache#3169, apache#3563;
|
Run Gluten Clickhouse CI |
|
@KevinyhZou @lgbo-ustc @taiyang-li please help to review, thanks. |
liuneng1994
approved these changes
Nov 10, 2023
|
LGTM |
lwz9103
pushed a commit
that referenced
this pull request
Nov 10, 2023
… when executing convert string to date (#3671) PR #3169 add some functions to convert string to date, which leads to performance regression serious. Will be reverted first and raise another pr to fix the issue later. Test case, 2000W records: before PR #3169 : 3s after PR #3169: 3.6m Related PR: #3169, #3563;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
PR #3169 add some functions to convert string to date, which leads to performance regression serious. Will be reverted first and raise another pr to fix the issue later.
Test case, 2000W records:
before PR #3169 : 3s
after PR #3169: 3.6m
Related PR: #3169, #3563;
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)