Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3670][CH] Support escape with excel format #3674

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

loneylee
Copy link
Member

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #3670-ID)

How was this patch tested?

Test by ut

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

@loneylee loneylee changed the title [CH-3670] Support escape with excel format [GLUTEN-3670][CH] Support escape with excel format Nov 10, 2023
Copy link

#3670

@loneylee
Copy link
Member Author

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

1 similar comment
@loneylee
Copy link
Member Author

Run Gluten Clickhouse CI

@taiyang-li
Copy link
Contributor

LGTM

Copy link
Contributor

@baibaichen baibaichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baibaichen baibaichen merged commit 70061ac into apache:main Nov 13, 2023
17 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3674_time.csv log/native_master_11_12_2023_5b632f64e_time.csv difference percentage
q1 33.89 35.06 1.171 103.46%
q2 25.07 24.58 -0.487 98.06%
q3 37.22 37.43 0.208 100.56%
q4 35.59 36.90 1.314 103.69%
q5 70.85 71.39 0.539 100.76%
q6 6.81 7.07 0.255 103.75%
q7 84.39 82.01 -2.383 97.18%
q8 86.80 86.35 -0.445 99.49%
q9 127.75 121.45 -6.304 95.07%
q10 46.29 44.24 -2.047 95.58%
q11 19.49 20.06 0.576 102.96%
q12 25.27 25.25 -0.017 99.93%
q13 46.50 46.66 0.161 100.35%
q14 17.38 14.90 -2.473 85.77%
q15 27.36 27.08 -0.273 99.00%
q16 15.34 14.92 -0.420 97.26%
q17 101.05 99.68 -1.367 98.65%
q18 149.10 147.54 -1.567 98.95%
q19 13.99 12.97 -1.015 92.74%
q20 27.70 28.14 0.445 101.61%
q21 218.38 220.95 2.562 101.17%
q22 12.89 13.04 0.149 101.16%
total 1229.10 1217.68 -11.419 99.07%

@loneylee loneylee deleted the 3670 branch November 14, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] Escape error when read csv use excel format
4 participants