Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-3676][CH] Enable TPCH Deicmal Test #3677

Merged
merged 6 commits into from
Dec 13, 2023
Merged

[GLUTEN-3676][CH] Enable TPCH Deicmal Test #3677

merged 6 commits into from
Dec 13, 2023

Conversation

loneylee
Copy link
Member

What changes were proposed in this pull request?

(Fixes: #3676)

How was this patch tested?

Test by ut

@github-actions GitHub Actions
Copy link

#3676

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

@baibaichen baibaichen changed the title [GLUTEN-3676][CH] Enable tpch deicmal sql [GLUTEN-3676][CH] Enable TPCH Deicmal Test Dec 13, 2023
@baibaichen
Copy link
Contributor

Let's create an issue for traceing ignored ut. We ignore a Decimal test in the PR of fixing decimal.

@loneylee
Copy link
Member Author

Let's create an issue for traceing ignored ut. We ignore a Decimal test in the PR of fixing decimal.

follow by issue #4026 .

baibaichen
baibaichen approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@baibaichen baibaichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baibaichen baibaichen merged commit a36c961 into apache:main Dec 13, 2023
18 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3677_time.csv log/native_master_12_12_2023_8c6f1643e_time.csv difference percentage
q1 33.98 33.75 -0.236 99.30%
q2 24.68 24.88 0.201 100.81%
q3 38.28 37.71 -0.573 98.50%
q4 38.86 37.86 -0.999 97.43%
q5 71.89 72.83 0.939 101.31%
q6 7.09 7.05 -0.042 99.41%
q7 86.76 86.50 -0.264 99.70%
q8 88.13 86.24 -1.887 97.86%
q9 123.41 125.50 2.092 101.70%
q10 45.01 44.68 -0.329 99.27%
q11 20.60 20.21 -0.385 98.13%
q12 24.60 25.06 0.464 101.89%
q13 47.02 46.58 -0.443 99.06%
q14 14.36 19.99 5.626 139.17%
q15 28.18 27.55 -0.638 97.74%
q16 15.55 15.86 0.306 101.96%
q17 104.08 103.27 -0.808 99.22%
q18 151.71 151.33 -0.377 99.75%
q19 12.81 13.89 1.083 108.46%
q20 29.79 28.68 -1.101 96.30%
q21 229.00 229.12 0.126 100.06%
q22 15.14 13.95 -1.192 92.13%
total 1250.93 1252.49 1.561 100.12%

@loneylee loneylee deleted the decimal branch December 25, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baibaichen baibaichen baibaichen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CH] Enable tpch decimal suite
3 participants
@loneylee @baibaichen @GlutenPerfBot