Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3635][VL] Clean up docs related to build-arrow paths #3709

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

ted-jenks
Copy link
Contributor

@ted-jenks ted-jenks commented Nov 14, 2023

What changes were proposed in this pull request?

As in #3635, gluten currently relies on arrow in Velox. This means the build-arrow stuff has been removed.

Most of the necessary docs changes were covered in https://github.com/oap-project/gluten/pull/3573/files but a couple small details were missed.

How was this patch tested?

Docs have been updated here to remove reference to the build-arrow paths.

Copy link

#3572

Copy link

Run Gluten Clickhouse CI

@ted-jenks ted-jenks changed the title [GLUTEN-3572][DOC] Clean up docs related to build-arrow paths [GLUTEN-3635][DOC] Clean up docs related to build-arrow paths Nov 14, 2023
Copy link

#3635

@ted-jenks ted-jenks changed the title [GLUTEN-3635][DOC] Clean up docs related to build-arrow paths [GLUTEN-3635][VL] Clean up docs related to build-arrow paths Nov 14, 2023
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fix! Just a small suggestion.

docs/developers/HowTo.md Outdated Show resolved Hide resolved
@ted-jenks ted-jenks requested a review from PHILO-HE November 15, 2023 11:26
Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@PHILO-HE PHILO-HE merged commit b2c62cd into apache:main Nov 15, 2023
15 of 17 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3709_time.csv log/native_master_11_14_2023_3e42cb06a_time.csv difference percentage
q1 33.37 33.71 0.346 101.04%
q2 24.74 23.76 -0.975 96.06%
q3 37.27 37.84 0.571 101.53%
q4 36.62 37.67 1.048 102.86%
q5 70.68 70.38 -0.298 99.58%
q6 5.47 7.15 1.678 130.68%
q7 81.62 86.97 5.350 106.56%
q8 85.86 84.81 -1.049 98.78%
q9 126.93 126.75 -0.189 99.85%
q10 46.28 45.72 -0.566 98.78%
q11 19.75 19.34 -0.415 97.90%
q12 25.63 27.31 1.682 106.56%
q13 46.35 46.23 -0.124 99.73%
q14 13.73 17.88 4.148 130.20%
q15 28.68 28.78 0.093 100.33%
q16 15.59 15.27 -0.320 97.95%
q17 100.80 98.37 -2.423 97.60%
q18 149.36 148.15 -1.210 99.19%
q19 12.87 13.28 0.410 103.19%
q20 27.01 27.14 0.130 100.48%
q21 221.69 222.13 0.435 100.20%
q22 12.80 12.90 0.104 100.81%
total 1223.09 1231.52 8.427 100.69%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_11_15_2023_time.csv log/native_master_11_14_2023_3e42cb06a_time.csv difference percentage
q1 34.44 33.71 -0.730 97.88%
q2 24.85 23.76 -1.091 95.61%
q3 38.05 37.84 -0.211 99.45%
q4 36.65 37.67 1.019 102.78%
q5 68.99 70.38 1.386 102.01%
q6 5.48 7.15 1.663 130.33%
q7 84.43 86.97 2.545 103.01%
q8 86.74 84.81 -1.927 97.78%
q9 124.14 126.75 2.602 102.10%
q10 45.35 45.72 0.361 100.80%
q11 19.43 19.34 -0.090 99.53%
q12 26.85 27.31 0.455 101.70%
q13 45.95 46.23 0.280 100.61%
q14 17.38 17.88 0.501 102.88%
q15 27.61 28.78 1.164 104.22%
q16 16.87 15.27 -1.609 90.47%
q17 99.28 98.37 -0.905 99.09%
q18 147.53 148.15 0.613 100.42%
q19 13.00 13.28 0.279 102.15%
q20 27.64 27.14 -0.500 98.19%
q21 222.20 222.13 -0.069 99.97%
q22 12.85 12.90 0.051 100.40%
total 1225.73 1231.52 5.788 100.47%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants