Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Error while reapplying Velox compilation patch when ENABLE_EP_CACHE=ON #3905

Closed
wants to merge 1 commit into from
Closed

[VL] Error while reapplying Velox compilation patch when ENABLE_EP_CACHE=ON #3905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ep/build-velox/src/build_velox.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ function compile {
fi
}

function check_commit {
# TODO: Move prepare_sourcecode to get_velox.sh
function prepare_sourcecode {
if [ $ENABLE_EP_CACHE == "ON" ]; then
if [ -f ${VELOX_HOME}/velox-commit.cache ]; then
CACHED_BUILT_COMMIT="$(cat ${VELOX_HOME}/velox-commit.cache)"
Expand All @@ -167,13 +168,16 @@ function check_commit {
exit 0
else
echo "Found cached commit $CACHED_BUILT_COMMIT for Velox which is different with target commit $TARGET_BUILD_COMMIT."
git reset --hard HEAD
fi
fi
fi
else
git clean -dffx :/
fi

apply_compilation_fixes $CURRENT_DIR $VELOX_HOME

if [ -f ${VELOX_HOME}/velox-commit.cache ]; then
rm -f ${VELOX_HOME}/velox-commit.cache
fi
Expand Down Expand Up @@ -264,8 +268,7 @@ if [ -z "$TARGET_BUILD_COMMIT" ]; then
fi
echo "Target Velox commit: $TARGET_BUILD_COMMIT"

check_commit
apply_compilation_fixes $CURRENT_DIR $VELOX_HOME
prepare_sourcecode
compile

echo "Successfully built Velox from Source."
Expand Down
Loading