[GLUTEN-3934][CH]Bug fix log function diff #3935
Merged
+211
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
3 similar comments
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
KevinyhZou
force-pushed
the
bug_fix_log_function_diff
branch
from
bd38343 to
13eaebd
Compare
|
Run Gluten Clickhouse CI |
taiyang-li
reviewed
Dec 6, 2023
| auto nullable_result_type = makeNullable(result_type); | ||
|
|
||
| const auto * null_const_node = addColumnToActionsDAG(actions_dag, nullable_result_type, Field()); | ||
| const auto * nullable_log_node = ActionsDAGUtil::convertNodeType(actions_dag, log_node, nullable_result_type->getName(), log_node->result_name); |
taiyang-li
reviewed
Dec 6, 2023
| throw Exception(ErrorCodes::NUMBER_OF_ARGUMENTS_DOESNT_MATCH, "Function {} requires exactly one arguments", getName()); | ||
|
|
||
| const auto * arg_node = parsed_args[0]; | ||
| const std::string function_name = getName(); |
There was a problem hiding this comment.
getName()返回的是substrait function name, 不是ch function name。这里不能混为一谈
taiyang-li
reviewed
Dec 6, 2023
| const auto * log_node = toFunctionNode(actions_dag, function_name, {arg_node}); | ||
|
|
||
| auto result_type = log_node->result_type; | ||
| auto nullable_result_type = makeNullable(result_type); |
There was a problem hiding this comment.
可以合并了，auto nullable_result_type = makeNullable(log_node->result_type);
taiyang-li
reviewed
Dec 6, 2023
| const auto * null_const_node = addColumnToActionsDAG(actions_dag, nullable_result_type, Field()); | ||
| const auto * nullable_log_node = ActionsDAGUtil::convertNodeType(actions_dag, log_node, nullable_result_type->getName(), log_node->result_name); | ||
| const DB::Float64 lowerBound = getParameterLowerBoundValue(); | ||
| const auto * le_node = toFunctionNode(actions_dag, "lessOrEquals", {arg_node, addColumnToActionsDAG(actions_dag, result_type, lowerBound)}); |
There was a problem hiding this comment.
lowerBound类型错了，应该是 arg_node的类型。
exmy
reviewed
Dec 6, 2023
| if (x <= c) | ||
| null | ||
| else | ||
| log(c) |
KevinyhZou
force-pushed
the
bug_fix_log_function_diff
branch
from
13eaebd to
9c2fbb4
Compare
|
Run Gluten Clickhouse CI |
KevinyhZou
force-pushed
the
bug_fix_log_function_diff
branch
from
9c2fbb4 to
8a6dda1
Compare
|
Fixed done. |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #3934)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
TEST BY UT