Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] switch to pre-built image for GHA #3966

Closed
wants to merge 3 commits into from

Conversation

zhouyuan
Copy link
Contributor

@zhouyuan zhouyuan commented Dec 7, 2023

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #ISSUE-ID)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

github-actions bot commented Dec 7, 2023

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

2 similar comments
Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

@@ -146,7 +146,7 @@ function compile {
function get_build_summary {
COMMIT_HASH=$1
# Ideally all script arguments should be put into build summary.
echo "ENABLE_S3=$ENABLE_S3,ENABLE_GCS=$ENABLE_GCS,ENABLE_HDFS=$ENABLE_HDFS,BUILD_TYPE=$BUILD_TYPE,VELOX_HOME=$VELOX_HOME,ENABLE_EP_CACHE=$ENABLE_EP_CACHE,ENABLE_BENCHMARK=$ENABLE_BENCHMARK,ENABLE_TESTS=$ENABLE_TESTS,RUN_SETUP_SCRIPT=$RUN_SETUP_SCRIPT,OTHER_ARGUMENTS=$OTHER_ARGUMENTS,COMMIT_HASH=$COMMIT_HASH"
echo "ENABLE_S3=$ENABLE_S3,ENABLE_GCS=$ENABLE_GCS,ENABLE_HDFS=$ENABLE_HDFS,BUILD_TYPE=$BUILD_TYPE,ENABLE_EP_CACHE=$ENABLE_EP_CACHE,ENABLE_BENCHMARK=$ENABLE_BENCHMARK,ENABLE_TESTS=$ENABLE_TESTS,RUN_SETUP_SCRIPT=$RUN_SETUP_SCRIPT,OTHER_ARGUMENTS=$OTHER_ARGUMENTS,COMMIT_HASH=$COMMIT_HASH"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll help trying if readlink -f could be a solution later

@zhouyuan zhouyuan force-pushed the wip_ci_image_update branch from 22ca604 to 52884f9 Compare December 7, 2023 06:52
Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

@apache apache deleted a comment from github-actions bot Dec 7, 2023
@apache apache deleted a comment from github-actions bot Dec 7, 2023
@zhouyuan zhouyuan force-pushed the wip_ci_image_update branch from e1a43df to 8f900b0 Compare December 7, 2023 08:01
Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

@zhouyuan zhouyuan force-pushed the wip_ci_image_update branch from f87e3dc to 5c69d95 Compare December 7, 2023 12:07
@apache apache deleted a comment from github-actions bot Dec 7, 2023
Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

1 similar comment
Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

@zhouyuan zhouyuan force-pushed the wip_ci_image_update branch from 58ec48f to b605c7c Compare December 7, 2023 13:17
Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

1 similar comment
Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

@zhouyuan zhouyuan closed this Dec 7, 2023
@zhouyuan zhouyuan force-pushed the wip_ci_image_update branch from f2fa970 to 9c5314f Compare December 7, 2023 14:18
@zhouyuan zhouyuan reopened this Dec 7, 2023
Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

1 similar comment
Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
@zhouyuan zhouyuan force-pushed the wip_ci_image_update branch from b8c79a7 to b2982ab Compare December 8, 2023 03:50
Copy link

github-actions bot commented Dec 8, 2023

Run Gluten Clickhouse CI

Signed-off-by: Yuan Zhou <[email protected]>
Copy link

github-actions bot commented Dec 8, 2023

Run Gluten Clickhouse CI

@zhouyuan zhouyuan closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants