Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Fix aggregation dumpped as json string #3969

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

marin-ma
Copy link
Contributor

@marin-ma marin-ma commented Dec 7, 2023

Fix below error when try to dump the json plan:

132 W20231207 01:54:01.932435 4101830 VeloxRuntime.cc:46] Error converting Substrait plan to JSON: BinaryToJsonStream returned INTERNAL:Invalid type URL, type URLs must be of the form '/<typename>', got: type.googleapis.com/google.protobuf.StringValue

Copy link

github-actions bot commented Dec 7, 2023

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Dec 8, 2023

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@ulysses-you ulysses-you merged commit e5a6dfa into apache:main Dec 13, 2023
17 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3969_time.csv log/native_master_12_12_2023_8c6f1643e_time.csv difference percentage
q1 34.20 33.75 -0.454 98.67%
q2 26.13 24.88 -1.250 95.22%
q3 37.74 37.71 -0.036 99.90%
q4 39.64 37.86 -1.782 95.50%
q5 69.73 72.83 3.099 104.44%
q6 6.85 7.05 0.204 102.98%
q7 84.98 86.50 1.518 101.79%
q8 85.50 86.24 0.741 100.87%
q9 127.07 125.50 -1.563 98.77%
q10 44.15 44.68 0.532 101.21%
q11 20.05 20.21 0.161 100.80%
q12 25.45 25.06 -0.391 98.46%
q13 45.93 46.58 0.650 101.42%
q14 17.72 19.99 2.263 112.77%
q15 28.07 27.55 -0.522 98.14%
q16 15.37 15.86 0.486 103.16%
q17 103.61 103.27 -0.347 99.67%
q18 151.67 151.33 -0.336 99.78%
q19 13.68 13.89 0.210 101.54%
q20 28.75 28.68 -0.065 99.78%
q21 224.21 229.12 4.918 102.19%
q22 13.83 13.95 0.127 100.92%
total 1244.33 1252.49 8.166 100.66%

kecookier pushed a commit to kecookier/gluten that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants