[GLUTEN-3983][CORE] Shade Guava dependency #3984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
PHILO-HE
changed the title
|
@zwangsheng, thanks for your fix! Please rebase the code to fix red CI. |
ulysses-you
reviewed
Dec 12, 2023
| </excludes> | ||
| </relocation> | ||
| <relocation> | ||
| <pattern>com.google.thirdparty</pattern> |
There was a problem hiding this comment.
Can we also shade com.google.j2objc and com.google.gson ? I saw the Spark connect Server module shade these things and I think it's reasonable.
There was a problem hiding this comment.
Sure, i'll do rebase and shade those.
zwangsheng
force-pushed
the
GLUTEN##3983
branch
from
83342c0 to
5c4605f
Compare
|
Run Gluten Clickhouse CI |
|
Hi @PHILO-HE @ulysses-you , rebased and continue shade |
|
Run Gluten Clickhouse CI |
ulysses-you
approved these changes
Dec 12, 2023
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Shaded Guava in gluten-package
Fixs: #3983
How was this patch tested?
Local Package Test