-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE] Add expression blacklist #3985
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
007b364
to
07ba0ba
Compare
Run Gluten Clickhouse CI |
07ba0ba
to
752f79d
Compare
Run Gluten Clickhouse CI |
752f79d
to
0217730
Compare
Run Gluten Clickhouse CI |
0217730
to
68efb5f
Compare
Run Gluten Clickhouse CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! Could you please update Configuration.md?
@@ -1252,6 +1261,12 @@ object GlutenConfig { | |||
.stringConf | |||
.createWithDefaultString("") | |||
|
|||
val EXPRESSION_BLACK_LIST = | |||
buildStaticConf("spark.gluten.expression.backlist") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: blacklist
68efb5f
to
08c10c0
Compare
Run Gluten Clickhouse CI |
08c10c0
to
a08e29a
Compare
Run Gluten Clickhouse CI |
thank you @PHILO-HE for the reminder, addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! cc @baibaichen, please note this change.
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
This pr adds a new config
spark.gluten.expression.blacklist
to fast skip transform expression. It can be used when we find bug for expression or do some debug.How was this patch tested?
add test