Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Make it easier to replay GHA CI scripts from local environment with docker support: Phase 1 #3998

Merged
merged 9 commits into from
Dec 12, 2023

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Dec 11, 2023

The patch targets to make user be able to replay GHA CI scripts from local host without extra effort to build the required docker images. (phase 1)

Phase 1:
Prepare necessary gluten-te utility scripts without changing CI script.

How should the newly added gha scripts be used:

# Create docker container and checkout code into it (to replace the use of GHA checkout plugin)
OS_IMAGE=centos:7 /opt/gluten/tools/gluten-te/centos/gha/gha-checkout/checkout.sh
# Or (if having cache registry set)
DOCKER_CACHE_REGISTRY=my.registry:5000 OS_IMAGE=centos:7 /opt/gluten/tools/gluten-te/centos/gha/gha-checkout/checkout.sh

# Execute some commands (build, test, etc)
/opt/gluten/tools/gluten-te/centos/gha/gha-checkout/exec.sh 'yum -y install epel-release centos-release-scl patch'

# Clean up the container before job exits
/opt/gluten/tools/gluten-te/centos/gha/gha-checkout/clean.sh

We should make actual changes to GHA CI script after phase 1 is merged.

** How to replay GHA CI scripts after this patch (and phase 2)

Setting the following environment variables before running the scripts:

export GITHUB_RUN_ID=<any id is OK here>
export TARGET_GLUTEN_COMMIT=<the target Gluten commit to test against>

Then checkout, then run scripts, all the same with the scripts in CI:

# checkout
OS_IMAGE=centos:7 /opt/gluten/tools/gluten-te/centos/gha/gha-checkout/checkout.sh
# commands
/opt/gluten/tools/gluten-te/centos/gha/gha-checkout/exec.sh 'yum -y install epel-release centos-release-scl patch'
# cleanup
/opt/gluten/tools/gluten-te/centos/gha/gha-checkout/clean.sh

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

2 similar comments
Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer marked this pull request as ready for review December 11, 2023 06:59
@zhztheplayer zhztheplayer marked this pull request as draft December 11, 2023 07:00
Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

This reverts commit d3e09f5.

fixup

fixup

to be reverted

empty

to be reverted

fixup

fixup

fixup

fixup

fixup

fixup
Copy link

Run Gluten Clickhouse CI

2 similar comments
Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer changed the title WIP: [VL] Make it easier to replay GHA CI scripts from local environment with docker support WIP: [VL] Make it easier to replay GHA CI scripts from local environment with docker support: Phase 1 Dec 12, 2023
Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer marked this pull request as ready for review December 12, 2023 05:06
@zhztheplayer zhztheplayer changed the title WIP: [VL] Make it easier to replay GHA CI scripts from local environment with docker support: Phase 1 [VL] Make it easier to replay GHA CI scripts from local environment with docker support: Phase 1 Dec 12, 2023
@zhztheplayer
Copy link
Member Author

@PHILO-HE @zhouyuan

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@zhztheplayer zhztheplayer merged commit 9c98620 into apache:main Dec 12, 2023
24 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3998_time.csv log/native_master_12_11_2023_71ec720d4_time.csv difference percentage
q1 35.00 32.10 -2.908 91.69%
q2 25.04 24.79 -0.250 99.00%
q3 38.33 38.42 0.094 100.25%
q4 39.05 39.90 0.858 102.20%
q5 71.62 72.41 0.790 101.10%
q6 5.41 7.02 1.610 129.77%
q7 86.16 85.38 -0.784 99.09%
q8 86.31 86.65 0.336 100.39%
q9 128.11 126.76 -1.358 98.94%
q10 46.19 46.79 0.597 101.29%
q11 20.42 20.34 -0.074 99.64%
q12 25.94 26.95 1.010 103.89%
q13 46.75 45.56 -1.187 97.46%
q14 15.80 18.31 2.510 115.89%
q15 29.02 27.78 -1.247 95.70%
q16 15.67 15.83 0.160 101.02%
q17 102.27 101.57 -0.702 99.31%
q18 150.56 151.54 0.980 100.65%
q19 13.73 12.91 -0.825 94.00%
q20 27.15 26.84 -0.313 98.85%
q21 226.36 228.06 1.704 100.75%
q22 13.95 13.81 -0.138 99.01%
total 1248.85 1249.71 0.860 100.07%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants