Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-4012][CH] Add metrics for GenerateExecTransformer #4014

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

exmy
Copy link
Contributor

@exmy exmy commented Dec 12, 2023

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #4012)

How was this patch tested?

manual tests

Copy link

#4012

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@zzcclp
Copy link
Contributor

zzcclp commented Dec 21, 2023

please add a test case for this change

Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@zzcclp zzcclp merged commit 57f4df1 into apache:main Dec 26, 2023
18 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4014_time.csv log/native_master_12_25_2023_e7040cd12_time.csv difference percentage
q1 32.18 31.71 -0.475 98.52%
q2 25.75 25.25 -0.492 98.09%
q3 37.85 37.88 0.028 100.07%
q4 40.11 39.70 -0.415 98.97%
q5 72.91 72.46 -0.445 99.39%
q6 5.41 7.15 1.738 132.14%
q7 87.36 87.64 0.276 100.32%
q8 87.15 87.41 0.265 100.30%
q9 122.81 126.55 3.739 103.04%
q10 43.68 42.96 -0.725 98.34%
q11 20.00 19.94 -0.053 99.73%
q12 25.73 23.98 -1.749 93.20%
q13 46.47 47.08 0.607 101.31%
q14 17.87 14.65 -3.220 81.98%
q15 27.64 28.24 0.596 102.16%
q16 15.21 15.59 0.387 102.54%
q17 103.58 104.91 1.327 101.28%
q18 153.69 151.05 -2.635 98.29%
q19 13.93 12.72 -1.215 91.28%
q20 27.00 28.28 1.284 104.76%
q21 230.10 225.43 -4.667 97.97%
q22 13.83 14.57 0.732 105.29%
total 1250.25 1245.13 -5.115 99.59%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] Missing metrics for GenerateExecTransformer
3 participants