[GLUTEN-4218] fix: Fix Gluten CPP build breaks

[Surbhi-Vijay]

What changes were proposed in this pull request?

This PR fixes below two build issues:

1. While building gluten cpp with vcpkg, build is breaking with below error:

Adding "thrift" to dev/vcpkg/vcpkg.json dependencies resolves the issue.

(Fixes: #4218)

How was this patch tested?

Build passes after the fixes

[github-actions]

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

• Other pull requests

[zhouyuan]

@Surbhi-Vijay thanks for fixing, it's a little odd as we do have a GitHub action test for static building(centos 7 based) to check each commit, could you please share a bit on your building env?

[Surbhi-Vijay]

@Surbhi-Vijay thanks for fixing, it's a little odd as we do have a GitHub action test for static building(centos 7 based) to check each commit, could you please share a bit on your building env?

@zhouyuan I am compiling gluten and velox with vcpkg by following the commands below on Ubuntu 22.04.3 LTS

sudo -E ./dev/vcpkg/setup-build-depends.sh
source ./dev/vcpkg/env.sh

./build_velox.sh --build_type=Debug

cmake -DBUILD_VELOX_BACKEND=ON -DVELOX_HOME=/home/surbhi/work/repos/OSS/gluten/ep/build-velox/build/velox_ep -DARROW_HOME=/home/surbhi/work/repos/OSS/gluten/ep/build-velox/build/velox_ep/_build/debug/third_party/arrow_ep -DCMAKE_BUILD_TYPE=Debug ..

mvn install spotless:apply -Pbackends-velox -Prss -Pspark-3.3 -Pspark-ut -DskipTests

[gaoyangxiaozhu]

@Surbhi-Vijay thanks for fixing, it's a little odd as we do have a GitHub action test for static building(centos 7 based) to check each commit, could you please share a bit on your building env?

hey @zhouyuan , this is the issue we encoutnered after last sync and we fix by add thrift in VCPKG.json

[zhouyuan]

@Surbhi-Vijay can you please do a rebase? the failure on boost download should be fixed now

thanks, -yuan

[zhouyuan]

👍

[GlutenPerfBot]

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query	log/native_4217_time.csv	log/native_master_01_08_2024_b81ecdef1_time.csv	difference	percentage
q1	33.44	33.20	-0.242	99.28%
q2	25.62	25.74	0.119	100.47%
q3	37.96	38.04	0.078	100.20%
q4	39.28	39.01	-0.269	99.31%
q5	70.63	71.87	1.248	101.77%
q6	7.04	8.18	1.139	116.19%
q7	87.14	85.51	-1.632	98.13%
q8	86.37	85.98	-0.389	99.55%
q9	127.70	122.63	-5.071	96.03%
q10	43.83	43.71	-0.123	99.72%
q11	19.64	20.14	0.496	102.52%
q12	25.74	27.54	1.792	106.96%
q13	46.09	46.35	0.262	100.57%
q14	16.20	18.04	1.843	111.38%
q15	28.31	28.07	-0.240	99.15%
q16	15.39	15.33	-0.062	99.60%
q17	160.25	157.40	-2.848	98.22%
q18	195.36	196.16	0.798	100.41%
q19	16.57	16.55	-0.017	99.90%
q20	28.71	29.10	0.387	101.35%
q21	227.59	226.46	-1.132	99.50%
q22	13.93	14.01	0.082	100.59%
total	1352.79	1349.01	-3.783	99.72%