-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Followup for native write files #4246
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
backends-velox/src/main/scala/org/apache/spark/sql/execution/VeloxColumnarWriteFilesExec.scala
Show resolved
Hide resolved
backends-velox/src/main/scala/org/apache/spark/sql/execution/VeloxColumnarWriteFilesExec.scala
Show resolved
Hide resolved
@JkSelf any more comments ? |
LGTM. The ck backend failed. Can you help to fix? |
it seems it's irrelevant with this pr, all tests paased but finally jenkin failed to post status.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
This pr is a followup for #3690 to solve some issues:
HiveFileFormat
for Spark3.4 shimVeloxWriteFilesMetrics
for velox table write result json stringVeloxColumnarWriteFilesExec
inherit GlutenPlan to avoid wrong fallback reportHow was this patch tested?
add test