Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3582][CH] Remove ArrowParquetBlockInputFormat and OptimizedParquetBlockInputFormat #4626

Merged
merged 3 commits into from
Feb 4, 2024

Conversation

baibaichen
Copy link
Contributor

What changes were proposed in this pull request?

ArrowParquetBlockInputFormat and OptimizedParquetBlockInputFormat are unmaintainable, let's remove them.

Note

With this PR , "spark.gluten.sql.columnar.backend.ch.runtime_config.use_local_format" is temporarily broken,I will fix it in next PR.

(Fixes: #3582)

How was this patch tested?

Using existed UTs

Copy link

github-actions bot commented Feb 2, 2024

#3582

Copy link

github-actions bot commented Feb 2, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Feb 2, 2024

Run Gluten Clickhouse CI

@baibaichen baibaichen force-pushed the feature/remove_ch_arrow branch from a055b56 to ccfae35 Compare February 4, 2024 02:04
Copy link

github-actions bot commented Feb 4, 2024

Run Gluten Clickhouse CI

Copy link
Contributor

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baibaichen baibaichen merged commit 9e1e5d5 into apache:main Feb 4, 2024
7 checks passed
@baibaichen baibaichen deleted the feature/remove_ch_arrow branch February 4, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] Improve parquet reader performacne
2 participants