-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-3378][VL][FOLLOWUP] Use List to store Iceberg delete files #4971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @yma11, thanks. |
Run Gluten Clickhouse CI |
liujiayi771
changed the title
[VL] Use List to store delete file info
[GLUTEN-3378][VL][FOLLOWUP] Use List to store delete file info
Mar 15, 2024
Run Gluten Clickhouse CI |
liujiayi771
changed the title
[GLUTEN-3378][VL][FOLLOWUP] Use List to store delete file info
[GLUTEN-3378][VL][FOLLOWUP] Use List to store Iceberg delete files
Mar 15, 2024
@yma11 Could you help review? |
yma11
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just wait for CI complete.
@yma11 I will rebase the main branch. |
liujiayi771
force-pushed
the
iceberg-deletefile-list
branch
from
March 19, 2024 03:34
1c591c2
to
b611cf6
Compare
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
liujiayi771
force-pushed
the
iceberg-deletefile-list
branch
from
March 19, 2024 06:49
b611cf6
to
9876104
Compare
Run Gluten Clickhouse CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The file information such as
paths
andstarts
stored inLocalFilesNode
is organized and stored usingList
. Iceberg delete files should also use this form to make the code structure more unified.How was this patch tested?
Exists CI.