Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3378][VL][FOLLOWUP] Use List to store Iceberg delete files #4971

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

liujiayi771
Copy link
Contributor

What changes were proposed in this pull request?

The file information such as paths and starts stored in LocalFilesNode is organized and stored using List. Iceberg delete files should also use this form to make the code structure more unified.

How was this patch tested?

Exists CI.

@liujiayi771
Copy link
Contributor Author

cc @yma11, thanks.

Copy link

Run Gluten Clickhouse CI

@liujiayi771 liujiayi771 changed the title [VL] Use List to store delete file info [GLUTEN-3378][VL][FOLLOWUP] Use List to store delete file info Mar 15, 2024
Copy link

#3378

Copy link

Run Gluten Clickhouse CI

@liujiayi771 liujiayi771 changed the title [GLUTEN-3378][VL][FOLLOWUP] Use List to store delete file info [GLUTEN-3378][VL][FOLLOWUP] Use List to store Iceberg delete files Mar 15, 2024
@liujiayi771
Copy link
Contributor Author

@yma11 Could you help review?

Copy link
Contributor

@yma11 yma11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just wait for CI complete.

@liujiayi771
Copy link
Contributor Author

@yma11 I will rebase the main branch.

@liujiayi771 liujiayi771 force-pushed the iceberg-deletefile-list branch from 1c591c2 to b611cf6 Compare March 19, 2024 03:34
Copy link

Run Gluten Clickhouse CI

1 similar comment
@liujiayi771
Copy link
Contributor Author

Run Gluten Clickhouse CI

@liujiayi771 liujiayi771 force-pushed the iceberg-deletefile-list branch from b611cf6 to 9876104 Compare March 19, 2024 06:49
Copy link

Run Gluten Clickhouse CI

@PHILO-HE PHILO-HE merged commit bb04647 into apache:main Mar 20, 2024
17 checks passed
@liujiayi771 liujiayi771 deleted the iceberg-deletefile-list branch March 20, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants