Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL]: Fix VeloxColumnarWriteFilesExecwithNewChildren doesn't replace the dummy child #5726

Merged
merged 3 commits into from
May 13, 2024

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented May 13, 2024

This is a bugfix extracted from PR #5698.

Tested locally.

fixup

fixup

fixup

fixup

fixup

fixup

fixup

UI
This reverts commit 834aff9.
@zhztheplayer zhztheplayer marked this pull request as ready for review May 13, 2024 07:50
Copy link
Contributor

@JkSelf JkSelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your fix.

@apache apache deleted a comment from github-actions bot May 13, 2024
@zhztheplayer zhztheplayer merged commit 600a5ee into apache:main May 13, 2024
40 of 41 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5726_time.csv log/native_master_05_11_2024_4899ea5c8_time.csv difference percentage
q1 34.92 33.75 -1.174 96.64%
q2 23.29 23.55 0.260 101.11%
q3 35.59 38.11 2.517 107.07%
q4 39.29 37.13 -2.157 94.51%
q5 68.17 68.76 0.593 100.87%
q6 7.50 7.57 0.076 101.01%
q7 83.07 82.51 -0.560 99.33%
q8 83.73 82.99 -0.743 99.11%
q9 120.10 120.65 0.553 100.46%
q10 44.67 45.36 0.698 101.56%
q11 20.09 20.15 0.063 100.31%
q12 26.25 30.08 3.836 114.61%
q13 56.27 53.02 -3.254 94.22%
q14 17.99 20.74 2.752 115.30%
q15 30.71 30.86 0.149 100.48%
q16 13.64 13.92 0.275 102.02%
q17 104.17 101.26 -2.910 97.21%
q18 146.11 146.46 0.354 100.24%
q19 13.47 15.45 1.984 114.74%
q20 28.11 26.42 -1.690 93.99%
q21 281.96 284.10 2.132 100.76%
q22 16.04 16.40 0.360 102.24%
total 1295.13 1299.24 4.113 100.32%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants