-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-5731][CORE] Fix the logic to calculate rss shuffle write time #5742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RssPartitionWriter
marin-ma
changed the title
[GLUTEN-5731][CORE] Fix the logic to calculate shuffle write time
[GLUTEN-5731][CORE] Fix the logic to calculate rss shuffle write time
May 15, 2024
@kerwin-zk Could you help to confirm this change? Thanks! |
kerwin-zk
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.Thanks!
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change the logic to calculate the shuffle write time. Shuffle write time is currently composed of splitResult.getTotalWriteTime + splitResult.getTotalPushTime
And TotalWriteTime in the current implementation is added twice into the final shuffle write time metric.
(Fixes: #5731)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
E2e manual test.