-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE] Enable SortShuffleSuite with ColumnarShuffleManager #5816
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
@rui-mo @zhli1142015 can you please review? |
Hi @zzcclp, do we need to exclude this suite for CH backend? Thanks. |
@acvictor Could you rebase this PR to try the CH CI again? Thanks. |
Run Gluten Clickhouse CI |
@rui-mo I think the Clickhouse CI has failed but I'm not sure how to access it. Should I disable the suite for CH? |
@acvictor We provide an account to log into CH CI system at https://github.com/apache/incubator-gluten/blob/main/docs/get-started/ClickHouse.md#new-ci-system.
But I find the failure looks irrelevant to this change. @zzcclp Could you help confirm? |
please help to exclude the GlutenSortShuffleSuite for CH backend first, thanks. |
…acvictor/gluten into users/acvictor/enableShuffleUTs
Done. Can you please review? |
Run Gluten Clickhouse CI |
…acvictor/enableShuffleUTs
Run Gluten Clickhouse CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Will merge after CI passes.
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
Enable Spark's SortShuffleSuite with shuffle manager set to ColumnarShuffleManager to ensure that shuffle is always compatible with existing Spark cases.
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
Added a new test suite.