Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VL] RAS: Add config option for setting user cost model, remove fallback strategies from RAS rules list #5861

Merged
merged 12 commits into from
May 27, 2024
Merged

[VL] RAS: Add config option for setting user cost model, remove fallback strategies from RAS rules list #5861

merged 12 commits into from
May 27, 2024

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented May 24, 2024 •
edited
Loading

In RAS:

  1. Remove use of rule ExpandFallbackPolicy and FallbackMultiCodegens from RAS planner
  2. Add config option spark.gluten.ras.costModel for setting user-defined cost model
  3. RAS config option changed from spark.gluten.sql.ras.enabled to spark.gluten.ras.enabled
  4. Fix a bug caused by rule RemoveFilter

@apache apache deleted a comment from github-actions bot May 24, 2024
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

1 similar comment
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer changed the title [VL] RAS: Add user cost model support, remove fallback strategies from RAS planner [VL] RAS: Add config option for setting user cost model, remove fallback strategies from RAS rules list May 24, 2024
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

1 similar comment
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer marked this pull request as ready for review May 27, 2024 01:27
@zhztheplayer zhztheplayer merged commit a07e3b8 into apache:main May 27, 2024
40 checks passed
@zhztheplayer zhztheplayer mentioned this pull request May 27, 2024
Merged
zhztheplayer added a commit that referenced this pull request May 28, 2024
@zhztheplayer
[VL] Following #5861, append some nit changes
12fdb70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JkSelf JkSelf JkSelf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhztheplayer @JkSelf