Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Following #5861, append some nit changes #5873

Merged
merged 1 commit into from
May 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ object RemoveFilter extends RasRule[SparkPlan] {
leaf(clazz(classOf[BasicScanExecTransformer]))
).build())

// A noop filter placeholder that indicates that all conditions are pushed into scan.
// A noop filter placeholder that indicates that all conditions are pushed down to scan.
//
// This operator has zero cost in cost model to avoid planner from choosing the
// original filter-scan that doesn't have all conditions pushed down to scan.
//
// We cannot simplify remove the filter to let planner choose the scan since by vanilla
// We cannot simply remove the filter to let planner choose the pushed scan since by vanilla
// Spark's definition the filter may have different output nullability than scan. So
// we have to keep this empty filter to let the optimized tree have the identical output schema
// with the original tree. If we simply remove the filter, possible UBs might be caused. For
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ object GlutenCostModel extends Logging {
// by vanilla Spark and was generated by strategy "JoinSelectionOverrides"
infLongCost
case _: RemoveFilter.NoopFilter =>
// To make planner choose the tree that has applied rule PushFilterToScan.
// To make planner choose the tree that has applied rule PushFilterToScan.
0L
case ColumnarToRowExec(child) => 3L
case RowToColumnarExec(child) => 3L
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1209,7 +1209,7 @@ object GlutenConfig {
val RAS_COST_MODEL =
buildConf("spark.gluten.ras.costModel")
.doc(
"Experimental: The classpath of user-defined cost model that will be used by RAS. " +
"Experimental: The class name of user-defined cost model that will be used by RAS. " +
"If not specified, a rough built-in cost model will be used.")
.stringConf
.createWithDefaultString("rough")
Expand Down
Loading