[GLUTEN-5890][Core] Enhance jni signature with a more readable way #5888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
Yohahaha
reviewed
May 28, 2024
| @@ -31,6 +31,11 @@ | |||
| #include "utils/exception.h" | |||
|
|
|||
| static jint jniVersion = JNI_VERSION_1_8; | |||
| static map<int, string> type2sig = buildTypeMapping(); | |||
zhli1142015
changed the title
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is to optimize current const text in code like "([B)V", which means the jbooleanArray with void return.
So we currently have this way for optimize:
We use typeid to get the hash of the type and build a map from type_info.hash_code to the signature.
How was this patch tested?
This is test in ut, for all the value equals to previous values.
And check for all single value.