Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Fix build error #5891

Merged
merged 1 commit into from
May 28, 2024
Merged

[VL] Fix build error #5891

merged 1 commit into from
May 28, 2024

Conversation

zhli1142015
Copy link
Contributor

@zhli1142015 zhli1142015 commented May 28, 2024

What changes were proposed in this pull request?

https://github.com/apache/incubator-gluten/actions/runs/9265491297/job/25487751879?pr=5754

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zhli1142015
Copy link
Contributor Author

cc @ulysses-you , thanks

Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@ulysses-you ulysses-you left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the quick fix!

@ulysses-you ulysses-you merged commit 63db789 into apache:main May 28, 2024
32 of 33 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5891_time.csv log/native_master_05_27_2024_efd6f31fb_time.csv difference percentage
q1 33.42 34.01 0.590 101.76%
q2 23.62 25.69 2.072 108.77%
q3 36.47 36.59 0.121 100.33%
q4 31.34 34.28 2.942 109.39%
q5 68.58 70.33 1.748 102.55%
q6 7.52 7.60 0.078 101.03%
q7 80.83 82.15 1.319 101.63%
q8 85.30 88.29 2.991 103.51%
q9 120.36 122.17 1.809 101.50%
q10 45.00 46.70 1.698 103.77%
q11 20.33 20.07 -0.253 98.76%
q12 27.47 23.62 -3.843 86.01%
q13 51.31 53.35 2.039 103.97%
q14 22.08 17.13 -4.952 77.58%
q15 29.76 31.65 1.882 106.32%
q16 14.36 13.86 -0.496 96.54%
q17 103.00 103.47 0.466 100.45%
q18 146.33 144.12 -2.210 98.49%
q19 15.70 13.72 -1.986 87.35%
q20 28.63 28.10 -0.539 98.12%
q21 260.78 260.32 -0.455 99.83%
q22 11.91 12.53 0.622 105.22%
total 1264.12 1269.76 5.644 100.45%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants