Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Following #5889, correct / simplify the table indenting algorithm #5917

Merged
merged 2 commits into from
May 30, 2024

Conversation

zhztheplayer
Copy link
Member

The patch just corrects the identing algorithm of #5889.

Copy link

Run Gluten Clickhouse CI

@apache apache deleted a comment from github-actions bot May 30, 2024
@zhztheplayer zhztheplayer changed the title [VL] Following #5889, correct / simplify the table identing algorithm [VL] Following #5889, correct / simplify the table indenting algorithm May 30, 2024
Copy link
Contributor

@JkSelf JkSelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@zhztheplayer zhztheplayer merged commit 1fd19a5 into apache:main May 30, 2024
39 of 41 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5917_time.csv log/native_master_05_29_2024_588faae35_time.csv difference percentage
q1 34.02 33.56 -0.457 98.66%
q2 24.10 23.85 -0.248 98.97%
q3 37.09 37.37 0.279 100.75%
q4 32.06 32.42 0.360 101.12%
q5 69.09 69.83 0.746 101.08%
q6 7.06 7.54 0.482 106.83%
q7 80.56 81.75 1.193 101.48%
q8 73.12 86.57 13.445 118.39%
q9 112.18 118.35 6.166 105.50%
q10 46.79 44.16 -2.631 94.38%
q11 20.51 22.23 1.723 108.40%
q12 23.05 26.72 3.671 115.93%
q13 53.55 53.60 0.051 100.09%
q14 20.68 17.59 -3.091 85.05%
q15 35.62 32.89 -2.732 92.33%
q16 12.22 13.41 1.182 109.67%
q17 99.62 103.62 3.999 104.01%
q18 145.19 144.53 -0.661 99.54%
q19 13.19 13.59 0.400 103.04%
q20 30.08 29.66 -0.425 98.59%
q21 256.98 260.43 3.442 101.34%
q22 13.79 13.84 0.051 100.37%
total 1240.56 1267.50 26.945 102.17%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants