-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Do not skip updating children's metrics while visiting an operator with NoopMetricsUpdater #5933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run Gluten Clickhouse CI |
zhztheplayer
changed the title
[VL] Do not skip updating children's metrics while visiting an operator with NoopMetricsUpdater
[CORE] Do not skip updating children's metrics while visiting an operator with NoopMetricsUpdater
May 31, 2024
zhztheplayer
force-pushed
the
wip-fix-noopmetrics
branch
from
May 31, 2024 03:55
740f5ba
to
0a98a1a
Compare
Run Gluten Clickhouse CI |
zhztheplayer
force-pushed
the
wip-fix-noopmetrics
branch
from
May 31, 2024 07:04
0a98a1a
to
9fc12be
Compare
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
zhztheplayer
changed the title
[CORE] Do not skip updating children's metrics while visiting an operator with NoopMetricsUpdater
[VL] Do not skip updating children's metrics while visiting an operator with NoopMetricsUpdater
May 31, 2024
zhztheplayer
force-pushed
the
wip-fix-noopmetrics
branch
from
May 31, 2024 07:38
7bb355d
to
147ae45
Compare
Run Gluten Clickhouse CI |
zhztheplayer
force-pushed
the
wip-fix-noopmetrics
branch
from
June 4, 2024 07:34
147ae45
to
b69cd4c
Compare
Run Gluten Clickhouse CI |
…or with NoopMetricsUpdater
zhztheplayer
force-pushed
the
wip-fix-noopmetrics
branch
from
June 4, 2024 07:59
b69cd4c
to
4cd484b
Compare
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
rui-mo
approved these changes
Jun 5, 2024
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly for fixing bug appearing only when RAS is enabled but could be generalized to all potential cases like NoopFilter in RAS.
Before:
After: