Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Do not skip updating children's metrics while visiting an operator with NoopMetricsUpdater #5933

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented May 31, 2024

This is mainly for fixing bug appearing only when RAS is enabled but could be generalized to all potential cases like NoopFilter in RAS.

Before:

image

After:

image

Copy link

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer changed the title [VL] Do not skip updating children's metrics while visiting an operator with NoopMetricsUpdater [CORE] Do not skip updating children's metrics while visiting an operator with NoopMetricsUpdater May 31, 2024
@apache apache deleted a comment from github-actions bot May 31, 2024
@zhztheplayer zhztheplayer force-pushed the wip-fix-noopmetrics branch from 740f5ba to 0a98a1a Compare May 31, 2024 03:55
Copy link

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer force-pushed the wip-fix-noopmetrics branch from 0a98a1a to 9fc12be Compare May 31, 2024 07:04
Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer changed the title [CORE] Do not skip updating children's metrics while visiting an operator with NoopMetricsUpdater [VL] Do not skip updating children's metrics while visiting an operator with NoopMetricsUpdater May 31, 2024
@zhztheplayer zhztheplayer force-pushed the wip-fix-noopmetrics branch from 7bb355d to 147ae45 Compare May 31, 2024 07:38
Copy link

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer force-pushed the wip-fix-noopmetrics branch from 147ae45 to b69cd4c Compare June 4, 2024 07:34
Copy link

github-actions bot commented Jun 4, 2024

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer force-pushed the wip-fix-noopmetrics branch from b69cd4c to 4cd484b Compare June 4, 2024 07:59
Copy link

github-actions bot commented Jun 4, 2024

Run Gluten Clickhouse CI

1 similar comment
Copy link

github-actions bot commented Jun 4, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Jun 4, 2024

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer marked this pull request as ready for review June 5, 2024 01:31
Copy link

github-actions bot commented Jun 5, 2024

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer merged commit 15c7c58 into apache:main Jun 5, 2024
39 of 40 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5933_time.csv log/native_master_06_04_2024_9755cdb6b_time.csv difference percentage
q1 35.83 33.66 -2.176 93.93%
q2 23.73 23.67 -0.059 99.75%
q3 39.90 35.00 -4.906 87.70%
q4 32.14 32.19 0.050 100.16%
q5 68.29 69.02 0.735 101.08%
q6 9.29 7.20 -2.096 77.44%
q7 80.19 82.19 2.002 102.50%
q8 83.29 83.65 0.358 100.43%
q9 118.86 120.88 2.019 101.70%
q10 43.70 45.81 2.108 104.82%
q11 20.29 20.00 -0.293 98.56%
q12 25.85 29.20 3.344 112.93%
q13 39.28 36.38 -2.901 92.62%
q14 19.78 22.03 2.250 111.37%
q15 33.54 29.83 -3.704 88.96%
q16 13.51 14.06 0.556 104.12%
q17 105.17 103.56 -1.611 98.47%
q18 145.58 147.26 1.686 101.16%
q19 14.84 13.50 -1.341 90.96%
q20 28.36 28.66 0.300 101.06%
q21 261.48 267.80 6.318 102.42%
q22 12.15 13.70 1.553 112.79%
total 1255.04 1259.23 4.193 100.33%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants