Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Remove reselect build side in ShuffledHashJoinExecTransformer #5935

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

zml1206
Copy link
Contributor

@zml1206 zml1206 commented May 31, 2024

What changes were proposed in this pull request?

After #5750 , velox backend supported use the smaller table to build hashmap in shuffled hash join ,preferredBuildSide in ShuffledHashJoinExecTransformer is unnecessary and not as accurate as AQE, so remove it.

How was this patch tested?

TPC-DS

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zml1206
Copy link
Contributor Author

zml1206 commented May 31, 2024

/Benchmark Velox TPCDS

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5935_time.csv log/native_master_05_30_2024_73eb21db45_time.csv difference percentage
q1 33.46 34.62 1.158 103.46%
q2 26.77 23.80 -2.976 88.88%
q3 36.56 37.04 0.477 101.30%
q4 34.97 32.22 -2.754 92.13%
q5 69.59 70.41 0.822 101.18%
q6 6.00 7.25 1.246 120.75%
q7 81.37 81.31 -0.058 99.93%
q8 84.88 85.87 0.987 101.16%
q9 121.36 118.14 -3.227 97.34%
q10 45.91 45.74 -0.176 99.62%
q11 22.84 21.64 -1.198 94.75%
q12 26.67 22.83 -3.840 85.60%
q13 36.50 52.00 15.493 142.45%
q14 18.79 18.87 0.077 100.41%
q15 29.94 32.69 2.751 109.19%
q16 14.52 13.77 -0.752 94.82%
q17 102.50 101.66 -0.842 99.18%
q18 144.80 143.98 -0.821 99.43%
q19 16.48 14.76 -1.724 89.54%
q20 26.74 28.58 1.848 106.91%
q21 258.49 265.55 7.068 102.73%
q22 12.25 14.49 2.246 118.34%
total 1251.39 1267.19 15.805 101.26%

Copy link
Member

@zhztheplayer zhztheplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PHILO-HE PHILO-HE merged commit 2713509 into apache:main Jun 4, 2024
39 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5935_time.csv log/native_master_06_02_2024_26ff58d3b_time.csv difference percentage
q1 34.44 33.06 -1.383 95.98%
q2 26.24 26.68 0.437 101.67%
q3 36.58 36.70 0.122 100.33%
q4 33.39 35.50 2.110 106.32%
q5 68.83 69.83 1.001 101.45%
q6 7.62 5.99 -1.631 78.60%
q7 80.58 81.70 1.127 101.40%
q8 84.93 84.47 -0.459 99.46%
q9 122.90 119.12 -3.773 96.93%
q10 43.51 45.39 1.883 104.33%
q11 19.83 20.18 0.350 101.76%
q12 28.37 25.30 -3.069 89.18%
q13 36.59 37.41 0.819 102.24%
q14 21.14 20.07 -1.068 94.95%
q15 30.39 30.21 -0.179 99.41%
q16 14.33 14.14 -0.183 98.72%
q17 100.84 101.99 1.153 101.14%
q18 146.09 147.16 1.076 100.74%
q19 16.80 17.14 0.346 102.06%
q20 26.74 26.85 0.101 100.38%
q21 265.41 259.27 -6.145 97.68%
q22 12.85 12.39 -0.463 96.40%
total 1258.40 1250.57 -7.828 99.38%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants