-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Upgrade simdjson to 3.9.3 in vcpkg build #5938
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
17ef4f4
to
deffb7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Just created a velox pr facebookincubator/velox#9997 to fix the below issue (vcpkg installed simdjson cannot be used by velox, instead velox still builds it from source):
|
@PHILO-HE Can you take this oppotunity to do a perf test of json parse? Masha said there is huge perf gain. Let's confirm from Gluten. |
@FelixYBW, I just did a small benchmark test with Spark. Velox with simdjson can bring 3x perf. gain, compared with vanilla spark. Simdjson's upgrading to version 3.93 brings 10% perf. gain, compared with the old simdjson version. |
This pr is ready to merge. The above warning only requires velox code change to fix. |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
See velox commit:
facebookincubator/velox@f9ae45a
How was this patch tested?
CI build.