Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-5939][CH] Support java timezone id named 'GMT+8' or 'GMT+08:00' #5940

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

loneylee
Copy link
Member

What changes were proposed in this pull request?

(Fixes: #5939)

How was this patch tested?

Test by ut

Copy link

#5939

Copy link

Run Gluten Clickhouse CI

@baibaichen
Copy link
Contributor

we need also support GMT+08:00

Copy link

Run Gluten Clickhouse CI

@baibaichen baibaichen changed the title [GLUTEN-5939][CH] Support java timezone id named 'GMT+8' [GLUTEN-5939][CH] Support java timezone id named 'GMT+8' or 'GMT+08:00' May 31, 2024
Copy link
Contributor

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baibaichen baibaichen merged commit 7a036dd into apache:main Jun 3, 2024
8 checks passed
@loneylee loneylee deleted the timezone branch June 3, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] Support java/scala timezone id on ch backend
4 participants