-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add CMake format check #5941
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
66d216c
to
5e2459d
Compare
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
I tried to put code format check for cpp/cpp-ch together and then will remove And I tried to use clang-format-15 in local (e.g., |
dev/check.sh ${{github.event.pull_request.base.sha}} | ||
git config --global --add safe.directory $GITHUB_WORKSPACE | ||
cd $GITHUB_WORKSPACE/ | ||
fileList=$(find ./cpp ./cpp-ch -name CMakeLists.txt -o -name *.cmake) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zzcclp, I'm adding to CI job to format CMake code (CMakeLists.txt & *.cmake), which also covers cpp-ch module. Please take a look to see if it's ok to you. Thanks!
@liuneng1994 @baibaichen please help to review and check, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Run Gluten Clickhouse CI |
@liuneng1994, do you have any comment? |
There is generally no problem, but subjectively, the effect of cmake-format seems to make some places more messy. |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
Example to use the format tool: