[VL] Fix build package script on GHA #5969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
zhztheplayer
previously approved these changes
Jun 4, 2024
zhztheplayer
reviewed
Jun 4, 2024
| - name: Upload Artifact Arrow Jar | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| path: /root/.m2/repository/org/apache/arrow/ |
There was a problem hiding this comment.
@jinchengchenghh Would you please confirm whether we could replace this line with 2 explicit gluten jars? E.g.,
path: |
/root/.m2/repository/org/apache/arrow/.../arrow-dataset-<version>.jar
/root/.m2/repository/org/apache/arrow/.../arrow-cdata-<version>.jar
There was a problem hiding this comment.
Maybe not, I tried before, but failed by cannot find jar. I don't remember the detailed error message.
wangyum
reviewed
Jun 5, 2024
Signed-off-by: Yuan Zhou <[email protected]>
zhouyuan
force-pushed
the
wip_build_pacakge_update
branch
from
aaad05c to
16f6e03
Compare
wangyum
approved these changes
Jun 12, 2024
PHILO-HE
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch fixes the build package script by 1) adding the arrow jar 2) use the latest docker image
How was this patch tested?
local verified