Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Add gluten iceberg jar to bundle package #6008

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

leoluan2009
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #ISSUE-ID)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

github-actions bot commented Jun 7, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zhouyuan zhouyuan changed the title Add gluten iceberg jar to bundle package [VL] Add gluten iceberg jar to bundle package Jun 7, 2024
@zhouyuan
Copy link
Contributor

zhouyuan commented Jun 7, 2024

CC @yma11

@yma11
Copy link
Contributor

yma11 commented Jun 7, 2024

@leoluan2009 Thanks for contribution. For data lake support like iceberg and delta lake, we don't include them in Gluten jar as it's not used by all customers and will make the package fatter. Any reasons for your changes here?

@leoluan2009
Copy link
Contributor Author

@yma11 Iceberg profile is not active by default, if we manually enable it when building gluten, it means we need it to read/write iceberg table, so we should put it in Gluten jar for easy deployment?

@yma11
Copy link
Contributor

yma11 commented Jun 7, 2024

@yma11 Iceberg profile is not active by default, if we manually enable it when building gluten, it means we need it to read/write iceberg table, so we should put it in Gluten jar for easy deployment?

I get your point. In this way, we don't need extra include of the gluten-iceberg-* jar file. So I think you need update this doc as well.

@leoluan2009
Copy link
Contributor Author

@yma11 updated doc, can you help to review again? thanks

docs/get-started/Velox.md Outdated Show resolved Hide resolved
@leoluan2009
Copy link
Contributor Author

@yma11 Thanks for your review, I have updated doc by your comment

@yma11 yma11 merged commit d3bd3d7 into apache:main Jun 11, 2024
38 checks passed
liujiayi771 added a commit that referenced this pull request Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants