Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] RAS: Validate against all offloaded plan nodes to decide whether to do this offload #6017

Merged
merged 1 commit into from
Jun 11, 2024
Merged

[VL] RAS: Validate against all offloaded plan nodes to decide whether to do this offload #6017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions gluten-core/src/main/scala/org/apache/gluten/extension/columnar/enumerated/RasOffload.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,13 @@ object RasOffload {
validator.validate(from) match {
case Validator.Passed =>
val offloaded = base.offload(from)
offloaded match {
case t: GlutenPlan if !t.doValidate().isValid =>
// 4. If native validation fails on the offloaded node, return the
// original one.
from
case other =>
other
val offloadedNodes = offloaded.collect[GlutenPlan] { case t: GlutenPlan => t }
if (offloadedNodes.exists(!_.doValidate().isValid)) {
// 4. If native validation fails on the offloaded node, return the
// original one.
from
} else {
offloaded
}
case Validator.Failed(reason) =>
from
Expand Down
Loading