[VL] Pass file size and modification time in split #6029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
@FelixYBW can you please review this? Thank you! |
Yohahaha
previously approved these changes
Jun 10, 2024
Comment on lines
210
to
214
| // Spark 3.3 and later only have file size and modification time in PartitionedFile | ||
| def getFileSizeAndModificationTime(file: PartitionedFile): (Option[Long], Option[Long]) = { | ||
| (None, None) | ||
| } | ||
|
|
There was a problem hiding this comment.
we'd better keep pure abstract method in this file, just like other declaration.
There was a problem hiding this comment.
Updated, thank you!
|
Run Gluten Clickhouse CI |
Thank you for the review! |
|
The PR broken the S3 reader. quick fix: #6313 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support was made in Velox to pass file properties while creating a file handle for reading. Previously a separate call was made to fetch file properties from remote storage. By passing this information down to Velox in the split we save on one network call per file open.
facebookincubator/velox#9314
How was this patch tested?
Existing UTs